issue_comments

Table actions

5 rows where author_association = "MEMBER" and issue = 111795064 sorted by updated_at descending

✖
✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

issue 1

  • string coordinate gets converted to object coordinate upon addition of variable to dataset · 5 ✖

author_association 1

  • MEMBER · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
808803856 https://github.com/pydata/xarray/issues/627#issuecomment-808803856 https://api.github.com/repos/pydata/xarray/issues/627 MDEyOklzc3VlQ29tbWVudDgwODgwMzg1Ng== keewis 14808389 2021-03-27T21:19:33Z 2021-03-27T21:19:33Z MEMBER

it seems this should have been closed by #4759 (bisecting reveals that as the first good commit)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   string coordinate gets converted to object coordinate upon addition of variable to dataset 111795064
808797080 https://github.com/pydata/xarray/issues/627#issuecomment-808797080 https://api.github.com/repos/pydata/xarray/issues/627 MDEyOklzc3VlQ29tbWVudDgwODc5NzA4MA== andersy005 13301940 2021-03-27T20:20:47Z 2021-03-27T20:20:47Z MEMBER

This issue appears to have been resolved:

```python In [1]: import xarray as xr

In [2]: import numpy as np

In [3]: ds = xr.Dataset({"1": xr.DataArray(np.zeros(3), dims=["a"], coords={"a": list("xyz")})})

In [4]: ds Out[4]: <xarray.Dataset> Dimensions: (a: 3) Coordinates: * a (a) <U1 'x' 'y' 'z' Data variables: 1 (a) float64 0.0 0.0 0.0

In [5]: ds["2"] = xr.DataArray(np.zeros(2), dims=["a"], coords={"a": list("xy")})

In [6]: ds Out[6]: <xarray.Dataset> Dimensions: (a: 3) Coordinates: * a (a) <U1 'x' 'y' 'z' Data variables: 1 (a) float64 0.0 0.0 0.0 2 (a) float64 0.0 0.0 nan

```

I tested this with

python xarray: 0.17.0 pandas: 1.2.3 numpy: 1.20.1

Should we close this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   string coordinate gets converted to object coordinate upon addition of variable to dataset 111795064
468864681 https://github.com/pydata/xarray/issues/627#issuecomment-468864681 https://api.github.com/repos/pydata/xarray/issues/627 MDEyOklzc3VlQ29tbWVudDQ2ODg2NDY4MQ== max-sixty 5635139 2019-03-02T01:11:09Z 2019-03-02T01:11:09Z MEMBER

If this isn't an upstream pandas issue, let's reopen

(I'm not sure why @stalebot closed this - looks like it's not respecting the comments?)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   string coordinate gets converted to object coordinate upon addition of variable to dataset 111795064
459160754 https://github.com/pydata/xarray/issues/627#issuecomment-459160754 https://api.github.com/repos/pydata/xarray/issues/627 MDEyOklzc3VlQ29tbWVudDQ1OTE2MDc1NA== max-sixty 5635139 2019-01-31T00:01:55Z 2019-01-31T00:01:55Z MEMBER

Given that this is an index, are we dependent on pandas here?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   string coordinate gets converted to object coordinate upon addition of variable to dataset 111795064
148784572 https://github.com/pydata/xarray/issues/627#issuecomment-148784572 https://api.github.com/repos/pydata/xarray/issues/627 MDEyOklzc3VlQ29tbWVudDE0ODc4NDU3Mg== shoyer 1217238 2015-10-16T17:51:56Z 2015-10-16T17:51:56Z MEMBER

Thanks for the report -- this does seem like a bug to me. We do end up converting from fixed width strings to object quite often (to get around limitations of NumPy's strings), but adding in a variable should not change the type of any existing variables.

It's possible the best fix here will be to convert all string arrays into an object type as soon as they are loaded into xray objects.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   string coordinate gets converted to object coordinate upon addition of variable to dataset 111795064

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);