issue_comments

Table actions

5 rows where author_association = "MEMBER", issue = 109665577 and user = 5356122 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • clarkfitzg · 5 ✖

issue 1

  • allow passing coordinate names as x and y to plot methods · 5 ✖

author_association 1

  • MEMBER · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
146892645 https://github.com/pydata/xarray/pull/608#issuecomment-146892645 https://api.github.com/repos/pydata/xarray/issues/608 MDEyOklzc3VlQ29tbWVudDE0Njg5MjY0NQ== clarkfitzg 5356122 2015-10-09T14:46:14Z 2015-10-09T14:46:14Z MEMBER

thanks @jhamman for making it work!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow passing coordinate names as x and y to plot methods 109665577
146666438 https://github.com/pydata/xarray/pull/608#issuecomment-146666438 https://api.github.com/repos/pydata/xarray/issues/608 MDEyOklzc3VlQ29tbWVudDE0NjY2NjQzOA== clarkfitzg 5356122 2015-10-08T19:43:37Z 2015-10-08T19:43:37Z MEMBER

I think it's fine to have yincrease=True and xincrease=True everywhere as the defaults. This is how most people expect graphs to look. This is a place where internal consistency within xray probably beats conforming to the matplotlib defaults.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow passing coordinate names as x and y to plot methods 109665577
146554007 https://github.com/pydata/xarray/pull/608#issuecomment-146554007 https://api.github.com/repos/pydata/xarray/issues/608 MDEyOklzc3VlQ29tbWVudDE0NjU1NDAwNw== clarkfitzg 5356122 2015-10-08T13:59:07Z 2015-10-08T13:59:07Z MEMBER

Simplification of the logic is a good thing, so I'm fine with this.

We should call out the performance difference in the docs, maybe both in the main 2d plot section and the faceting section.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow passing coordinate names as x and y to plot methods 109665577
146392455 https://github.com/pydata/xarray/pull/608#issuecomment-146392455 https://api.github.com/repos/pydata/xarray/issues/608 MDEyOklzc3VlQ29tbWVudDE0NjM5MjQ1NQ== clarkfitzg 5356122 2015-10-08T01:58:13Z 2015-10-08T01:58:13Z MEMBER

With a 1000 x 1000 grid I'm seeing 10 ms for imshow compared to 200 ms for pcolormesh. And much longer to render. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow passing coordinate names as x and y to plot methods 109665577
146392233 https://github.com/pydata/xarray/pull/608#issuecomment-146392233 https://api.github.com/repos/pydata/xarray/issues/608 MDEyOklzc3VlQ29tbWVudDE0NjM5MjIzMw== clarkfitzg 5356122 2015-10-08T01:56:35Z 2015-10-08T01:56:35Z MEMBER

pcolormesh is more general, and works fine.

The problem, however, is time! How long does it take to plot and render with the two?

imshow can be orders of magnitude faster to plot and render.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow passing coordinate names as x and y to plot methods 109665577

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);