issue_comments

Table actions

12 rows where author_association = "MEMBER", issue = 109665577 and user = 2443309 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • jhamman · 12 ✖

issue 1

  • allow passing coordinate names as x and y to plot methods · 12 ✖

author_association 1

  • MEMBER · 12 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
146885534 https://github.com/pydata/xarray/pull/608#issuecomment-146885534 https://api.github.com/repos/pydata/xarray/issues/608 MDEyOklzc3VlQ29tbWVudDE0Njg4NTUzNA== jhamman 2443309 2015-10-09T14:22:31Z 2015-10-09T14:22:31Z MEMBER

Thanks @shoyer and @clarkfitzg for the input on this. Funny how a small change can sometime unravel into a much larger issue.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow passing coordinate names as x and y to plot methods 109665577
146758071 https://github.com/pydata/xarray/pull/608#issuecomment-146758071 https://api.github.com/repos/pydata/xarray/issues/608 MDEyOklzc3VlQ29tbWVudDE0Njc1ODA3MQ== jhamman 2443309 2015-10-09T05:26:46Z 2015-10-09T05:26:46Z MEMBER

I'm fine with adding a global option, but yes, we should wait until someone asks for that feature.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow passing coordinate names as x and y to plot methods 109665577
146656714 https://github.com/pydata/xarray/pull/608#issuecomment-146656714 https://api.github.com/repos/pydata/xarray/issues/608 MDEyOklzc3VlQ29tbWVudDE0NjY1NjcxNA== jhamman 2443309 2015-10-08T19:06:36Z 2015-10-08T19:06:36Z MEMBER

Yes, that was my motivation. Basically, switching to pcolormesh requires us to do this - the alternative is to add yincrease=True to all the 2d invocations of plot and pcolormesh in the docs.

I wouldn't say I have a comprehensive sense of how everyone orders their tick labels. In the earth sciences, which is my area of study, I'd say 95% of plots use the standard increasing y notation. The most common use cases for a decreasing y coordinate would probably be depth below the surface (where depth is increasingly positive).

One nice thing about setting yincrease=True by default, is that all our 2d plots come out with the same orientation. This is different than what you would get with matplotlib so I understand the hesitation. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow passing coordinate names as x and y to plot methods 109665577
146625084 https://github.com/pydata/xarray/pull/608#issuecomment-146625084 https://api.github.com/repos/pydata/xarray/issues/608 MDEyOklzc3VlQ29tbWVudDE0NjYyNTA4NA== jhamman 2443309 2015-10-08T17:04:06Z 2015-10-08T17:04:06Z MEMBER

I have updated the docs with a note about speed.

I also updated the default behavior of xincrease and yincrease from None to True. By going the pcolormesh route, it basically forces us to do that (which isn't a bad thing).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow passing coordinate names as x and y to plot methods 109665577
146582311 https://github.com/pydata/xarray/pull/608#issuecomment-146582311 https://api.github.com/repos/pydata/xarray/issues/608 MDEyOklzc3VlQ29tbWVudDE0NjU4MjMxMQ== jhamman 2443309 2015-10-08T15:39:28Z 2015-10-08T15:39:28Z MEMBER

I will add a bit to the docs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow passing coordinate names as x and y to plot methods 109665577
146393127 https://github.com/pydata/xarray/pull/608#issuecomment-146393127 https://api.github.com/repos/pydata/xarray/issues/608 MDEyOklzc3VlQ29tbWVudDE0NjM5MzEyNw== jhamman 2443309 2015-10-08T02:04:09Z 2015-10-08T02:04:09Z MEMBER

This is a good point. For me, its not a deal breaker though and the benefits of using pcolormesh all the time (simpler code, broad applicability) are worth the wait.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow passing coordinate names as x and y to plot methods 109665577
146341795 https://github.com/pydata/xarray/pull/608#issuecomment-146341795 https://api.github.com/repos/pydata/xarray/issues/608 MDEyOklzc3VlQ29tbWVudDE0NjM0MTc5NQ== jhamman 2443309 2015-10-07T21:43:58Z 2015-10-07T21:43:58Z MEMBER

So, are we okay with the default 2D plot being pcolormesh? It certainly simplifies things since we don't have to determine if the coords are uniform and it works for 1D and 2D coords.

I think @clarkfitzg may have an objection.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow passing coordinate names as x and y to plot methods 109665577
146341080 https://github.com/pydata/xarray/pull/608#issuecomment-146341080 https://api.github.com/repos/pydata/xarray/issues/608 MDEyOklzc3VlQ29tbWVudDE0NjM0MTA4MA== jhamman 2443309 2015-10-07T21:40:14Z 2015-10-07T21:40:14Z MEMBER

I started to go down the road of removing the squeeze you were talking about but _infer_interval_breaks got in my way (when len(coord) == 1). I think this is an important corner case but this PR is getting pretty cluttered so maybe it is best to save that for another.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow passing coordinate names as x and y to plot methods 109665577
146316096 https://github.com/pydata/xarray/pull/608#issuecomment-146316096 https://api.github.com/repos/pydata/xarray/issues/608 MDEyOklzc3VlQ29tbWVudDE0NjMxNjA5Ng== jhamman 2443309 2015-10-07T20:18:15Z 2015-10-07T20:18:15Z MEMBER

so you would have a DataArray of shape (1, 5) be plotted via pcolormesh (by default)?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow passing coordinate names as x and y to plot methods 109665577
146310923 https://github.com/pydata/xarray/pull/608#issuecomment-146310923 https://api.github.com/repos/pydata/xarray/issues/608 MDEyOklzc3VlQ29tbWVudDE0NjMxMDkyMw== jhamman 2443309 2015-10-07T19:58:10Z 2015-10-07T19:58:10Z MEMBER

Can we make it so the generic .plot(x='x2d', y='x2d') works?

How about making the default pcolormesh since that works in all cases?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow passing coordinate names as x and y to plot methods 109665577
146296448 https://github.com/pydata/xarray/pull/608#issuecomment-146296448 https://api.github.com/repos/pydata/xarray/issues/608 MDEyOklzc3VlQ29tbWVudDE0NjI5NjQ0OA== jhamman 2443309 2015-10-07T19:05:19Z 2015-10-07T19:05:19Z MEMBER

I think this is ready for a review. This fixes #611 and allows us to pass 2d coordinate names into plotting methods.

``` Python

Fixed FacetGrid labels

fg = da.plot.pcolormesh(col='time', col_wrap=4) ```

``` Python

2d coord names

ax = plt.axes(projection=Rasm()) ds.frac.plot.pcolormesh(x='xc', y='yc', transform=cartopy.crs.PlateCarree()) ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow passing coordinate names as x and y to plot methods 109665577
146082365 https://github.com/pydata/xarray/pull/608#issuecomment-146082365 https://api.github.com/repos/pydata/xarray/issues/608 MDEyOklzc3VlQ29tbWVudDE0NjA4MjM2NQ== jhamman 2443309 2015-10-07T05:44:32Z 2015-10-07T05:44:32Z MEMBER

...only handle two cases

This is exactly where I was headed. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   allow passing coordinate names as x and y to plot methods 109665577

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);