issue_comments

Table actions

2 rows where author_association = "MEMBER", issue = 1088893989 and user = 2448579 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date)

user 1

  • dcherian · 2 ✖

issue 1

  • Forward Fill not working when there are all-NaN chunks · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1001744349 https://github.com/pydata/xarray/issues/6112#issuecomment-1001744349 https://api.github.com/repos/pydata/xarray/issues/6112 IC_kwDOAMm_X847tWfd dcherian 2448579 2021-12-27T20:39:57Z 2021-12-27T20:39:57Z MEMBER

Both sound good to me.

Your code for limit looks OK though I didn't look closely. It looks very similar to https://github.com/pydata/xarray/blob/3960ea3ba08f81d211899827612550f6ac2de804/xarray/core/missing.py#L30-L34

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Forward Fill not working when there are all-NaN chunks 1088893989
1001667358 https://github.com/pydata/xarray/issues/6112#issuecomment-1001667358 https://api.github.com/repos/pydata/xarray/issues/6112 IC_kwDOAMm_X847tDse dcherian 2448579 2021-12-27T17:25:10Z 2021-12-27T17:25:10Z MEMBER

Thanks @josephnowak . This is a great idea! 👏🏾 👏🏾 Can you send in a pull request please? We'll need to add the example from your first post as a test.

I think you can replace this dask_array_ops.push with your version: https://github.com/pydata/xarray/blob/3960ea3ba08f81d211899827612550f6ac2de804/xarray/core/dask_array_ops.py#L56-L80

This function is expected to return a dask array, so you can just return the result of cumreduction instead of wrapping it up in a DataArray.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Forward Fill not working when there are all-NaN chunks 1088893989

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);