issue_comments

Table actions

3 rows where author_association = "MEMBER", issue = 1087126812 and user = 14371165 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • Illviljan · 3 ✖

issue 1

  • Regression in datetime handling in plots · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1003558676 https://github.com/pydata/xarray/issues/6102#issuecomment-1003558676 https://api.github.com/repos/pydata/xarray/issues/6102 IC_kwDOAMm_X8470RcU Illviljan 14371165 2022-01-01T13:21:59Z 2022-01-01T13:21:59Z MEMBER

Do you have an easy test in mind?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Regression in datetime handling in plots 1087126812
1000322721 https://github.com/pydata/xarray/issues/6102#issuecomment-1000322721 https://api.github.com/repos/pydata/xarray/issues/6102 IC_kwDOAMm_X847n7ah Illviljan 14371165 2021-12-23T13:57:35Z 2021-12-23T13:57:35Z MEMBER

There's a pr for reverting, #6064, for a separate reason that we probably should merge soon.

I simply don't understand what that registration does, it might well be just a quick fix in a time when mpl didn't support datetimes and it might be good idea to simplify and remove it in a future pr.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Regression in datetime handling in plots 1087126812
1000133347 https://github.com/pydata/xarray/issues/6102#issuecomment-1000133347 https://api.github.com/repos/pydata/xarray/issues/6102 IC_kwDOAMm_X847nNLj Illviljan 14371165 2021-12-23T08:35:17Z 2021-12-23T08:35:17Z MEMBER

The registration happens here, added in #1669 in 2017: https://github.com/pydata/xarray/blob/5e8de55321171f95ed9684c33aa47112bb2519ac/xarray/plot/utils.py#L34-L39

Is the registration even needed anymore I wonder? Matplotlib started supporting datetime64 in 2018: https://github.com/matplotlib/matplotlib/releases/tag/v2.2.0

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Regression in datetime handling in plots 1087126812

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);