issue_comments

Table actions

6 rows where author_association = "MEMBER" and issue = 1086360190 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • fix tests for h5netcdf v0.12 · 6 ✖

author_association 1

  • MEMBER · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1000511242 https://github.com/pydata/xarray/pull/6097#issuecomment-1000511242 https://api.github.com/repos/pydata/xarray/issues/6097 IC_kwDOAMm_X847opcK mathause 10194086 2021-12-23T20:29:33Z 2021-12-23T20:29:33Z MEMBER

thanks for the review!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix tests for h5netcdf v0.12 1086360190
1000416947 https://github.com/pydata/xarray/pull/6097#issuecomment-1000416947 https://api.github.com/repos/pydata/xarray/issues/6097 IC_kwDOAMm_X847oSaz kmuehlbauer 5821660 2021-12-23T16:42:07Z 2021-12-23T16:42:07Z MEMBER

@mathause I think it looks good. Thanks. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix tests for h5netcdf v0.12 1086360190
1000412795 https://github.com/pydata/xarray/pull/6097#issuecomment-1000412795 https://api.github.com/repos/pydata/xarray/issues/6097 IC_kwDOAMm_X847oRZ7 mathause 10194086 2021-12-23T16:33:46Z 2021-12-23T16:33:46Z MEMBER

I had a look at the tests & the failures are unrelated to h5netcdf. @kmuehlbauer if you are happy with the changes I would merge soon.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix tests for h5netcdf v0.12 1086360190
999562554 https://github.com/pydata/xarray/pull/6097#issuecomment-999562554 https://api.github.com/repos/pydata/xarray/issues/6097 IC_kwDOAMm_X847lB06 mathause 10194086 2021-12-22T13:05:47Z 2021-12-22T13:05:47Z MEMBER

There is an annoying amount of upstream failures. I just merged main - that should help a bit but unfortunately there are still open issues. - Some of them are fixed in #6096 - For some we are still waiting for a new dask release dask/dask#8482

Let's see what the CI says now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix tests for h5netcdf v0.12 1086360190
999407535 https://github.com/pydata/xarray/pull/6097#issuecomment-999407535 https://api.github.com/repos/pydata/xarray/issues/6097 IC_kwDOAMm_X847kb-v kmuehlbauer 5821660 2021-12-22T09:06:25Z 2021-12-22T09:06:25Z MEMBER

@mathause I think it would be great to test h5netcdf within the upstream tests to get notified early if something breaks.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix tests for h5netcdf v0.12 1086360190
999392411 https://github.com/pydata/xarray/pull/6097#issuecomment-999392411 https://api.github.com/repos/pydata/xarray/issues/6097 IC_kwDOAMm_X847kYSb kmuehlbauer 5821660 2021-12-22T08:43:37Z 2021-12-22T08:43:37Z MEMBER

@mathause See https://github.com/h5netcdf/h5netcdf/issues/100. h5netcdf changed this to raise CompatibilityError with latest version. Sorry for not bringing this to attention earlier.

Are the CI errors connected to changes in h5netcdf?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   fix tests for h5netcdf v0.12 1086360190

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);