issue_comments

Table actions

9 rows where author_association = "MEMBER", issue = 1048309254 and user = 5821660 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • kmuehlbauer · 9 ✖

issue 1

  • Fix module name retrieval in `backend.plugins.remove_duplicates()`, plugin tests · 9 ✖

author_association 1

  • MEMBER · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
968640994 https://github.com/pydata/xarray/pull/5959#issuecomment-968640994 https://api.github.com/repos/pydata/xarray/issues/5959 IC_kwDOAMm_X845vEni kmuehlbauer 5821660 2021-11-15T08:20:25Z 2021-11-15T08:20:25Z MEMBER

@alexamici Could you please have a final look into this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix module name retrieval in `backend.plugins.remove_duplicates()`, plugin tests 1048309254
964867173 https://github.com/pydata/xarray/pull/5959#issuecomment-964867173 https://api.github.com/repos/pydata/xarray/issues/5959 IC_kwDOAMm_X845grRl kmuehlbauer 5821660 2021-11-10T07:52:18Z 2021-11-10T07:52:18Z MEMBER

It seems that now the mocking works by specifying the correct import module string for importlib_metadata depending on which importlib is used.

That should be ready for another review.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix module name retrieval in `backend.plugins.remove_duplicates()`, plugin tests 1048309254
964224503 https://github.com/pydata/xarray/pull/5959#issuecomment-964224503 https://api.github.com/repos/pydata/xarray/issues/5959 IC_kwDOAMm_X845eOX3 kmuehlbauer 5821660 2021-11-09T14:52:27Z 2021-11-09T14:52:27Z MEMBER

I'll leave it as is for the next couple of days. I very much appreciate further reviews.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix module name retrieval in `backend.plugins.remove_duplicates()`, plugin tests 1048309254
964221223 https://github.com/pydata/xarray/pull/5959#issuecomment-964221223 https://api.github.com/repos/pydata/xarray/issues/5959 IC_kwDOAMm_X845eNkn kmuehlbauer 5821660 2021-11-09T14:48:59Z 2021-11-09T14:48:59Z MEMBER

That did not seem to work, I'll revert.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix module name retrieval in `backend.plugins.remove_duplicates()`, plugin tests 1048309254
964181699 https://github.com/pydata/xarray/pull/5959#issuecomment-964181699 https://api.github.com/repos/pydata/xarray/issues/5959 IC_kwDOAMm_X845eD7D kmuehlbauer 5821660 2021-11-09T14:05:32Z 2021-11-09T14:05:32Z MEMBER

It looks like these changes fix all pending issues. It would be very convenient to get a version 0.20.2 out in near time, since without it breaks testing of packages which implement xarray backends.

@snowman2 I think this is ready for test now with rioxarray.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix module name retrieval in `backend.plugins.remove_duplicates()`, plugin tests 1048309254
964132373 https://github.com/pydata/xarray/pull/5959#issuecomment-964132373 https://api.github.com/repos/pydata/xarray/issues/5959 IC_kwDOAMm_X845d34V kmuehlbauer 5821660 2021-11-09T13:04:38Z 2021-11-09T13:04:38Z MEMBER

Obviously we have an extensive set of tests for the backend plugins here (https://github.com/pydata/xarray/blob/ae3fea0251711c027427578933b82d982a07b242/xarray/tests/test_plugins.py) but it still uses pkg_resources, so trying to adapt to importlib.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix module name retrieval in `backend.plugins.remove_duplicates()`, plugin tests 1048309254
964107601 https://github.com/pydata/xarray/pull/5959#issuecomment-964107601 https://api.github.com/repos/pydata/xarray/issues/5959 IC_kwDOAMm_X845dx1R kmuehlbauer 5821660 2021-11-09T12:29:08Z 2021-11-09T12:29:08Z MEMBER

Finally, some test is breaking. This test uses the old pkg_resources way and needs to be updated too.

https://github.com/pydata/xarray/blob/ae3fea0251711c027427578933b82d982a07b242/xarray/tests/test_plugins.py#L29-L45

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix module name retrieval in `backend.plugins.remove_duplicates()`, plugin tests 1048309254
964102114 https://github.com/pydata/xarray/pull/5959#issuecomment-964102114 https://api.github.com/repos/pydata/xarray/issues/5959 IC_kwDOAMm_X845dwfi kmuehlbauer 5821660 2021-11-09T12:21:11Z 2021-11-09T12:21:11Z MEMBER

There seem to be two cases here.

  1. equal entrypoints, introduced by importlib machinery (pointing to the same module)
  2. multiple entrypoints with the same name (pointing to different modules)

The first is remove via set. The second is handled according the old machinery by extracting the modules from value.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix module name retrieval in `backend.plugins.remove_duplicates()`, plugin tests 1048309254
963929073 https://github.com/pydata/xarray/pull/5959#issuecomment-963929073 https://api.github.com/repos/pydata/xarray/issues/5959 IC_kwDOAMm_X845dGPx kmuehlbauer 5821660 2021-11-09T08:41:24Z 2021-11-09T08:41:24Z MEMBER

Although this makes the error go away, it doesn't do the right thing. I'll have to think about this more thoroughly.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix module name retrieval in `backend.plugins.remove_duplicates()`, plugin tests 1048309254

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);