issue_comments

Table actions

4 rows where author_association = "MEMBER" and issue = 1033884661 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 1

  • Use .to_numpy() for quantified facetgrids · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
954278227 https://github.com/pydata/xarray/pull/5886#issuecomment-954278227 https://api.github.com/repos/pydata/xarray/issues/5886 IC_kwDOAMm_X8444SFT dcherian 2448579 2021-10-28T22:41:53Z 2021-10-28T22:41:53Z MEMBER

Thanks @TomNicholas 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use .to_numpy() for quantified facetgrids  1033884661
954261248 https://github.com/pydata/xarray/pull/5886#issuecomment-954261248 https://api.github.com/repos/pydata/xarray/issues/5886 IC_kwDOAMm_X8444N8A Illviljan 14371165 2021-10-28T22:06:01Z 2021-10-28T22:06:01Z MEMBER

It would be nicer to know for certain that we are testing all the plot types with pint arrays, but I think that can maybe wait for another PR?

Agreed, it can wait for another time. This looks good to me. :)

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use .to_numpy() for quantified facetgrids  1033884661
954253465 https://github.com/pydata/xarray/pull/5886#issuecomment-954253465 https://api.github.com/repos/pydata/xarray/issues/5886 IC_kwDOAMm_X8444MCZ TomNicholas 35968931 2021-10-28T21:58:24Z 2021-10-28T21:58:24Z MEMBER

Did all of these changes print the warning?

I don't know - instead of testing all the cases I just made the .values->.to_numpy() change everywhere I could see. I think that makes sense given that: (a) there are tests elsewhere that should guarantee that those two methods are equivalent for non-pint arrays, (b) making those changes didn't break any existing tests, (c) .to_numpy() was intended to be the new default for calling within plotting code.

Would be nice if we could get these tested somehow.

I've added some tests for faceted line plots, faceted imshow, and faceted contourf. There is almost certainly some other type of plot or other edge case I haven't tested, but that's enough to show that this PR fixes what it intended to fix.

It would be nicer to know for certain that we are testing all the plot types with pint arrays, but I think that can maybe wait for another PR?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use .to_numpy() for quantified facetgrids  1033884661
950377397 https://github.com/pydata/xarray/pull/5886#issuecomment-950377397 https://api.github.com/repos/pydata/xarray/issues/5886 IC_kwDOAMm_X844pZu1 Illviljan 14371165 2021-10-24T19:06:00Z 2021-10-24T19:06:00Z MEMBER

Did all of these changes print the warning? Would be nice if we could get these tested somehow.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Use .to_numpy() for quantified facetgrids  1033884661

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);