issue_comments

Table actions

2 rows where author_association = "MEMBER" and issue = 1032233673 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • `open_mfdataset` does not handle single `pathlib.Path` objects but handles single `str` just fine · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
949050951 https://github.com/pydata/xarray/issues/5881#issuecomment-949050951 https://api.github.com/repos/pydata/xarray/issues/5881 IC_kwDOAMm_X844kV5H TomNicholas 35968931 2021-10-21T22:31:43Z 2021-10-21T22:31:43Z MEMBER

In fact in light of https://github.com/pydata/xarray/pull/5879, it should probably be python + elif isinstance(paths, os.PathLike): + paths = [str(paths)] instead.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `open_mfdataset` does not handle single `pathlib.Path` objects but handles single `str` just fine 1032233673
949049437 https://github.com/pydata/xarray/issues/5881#issuecomment-949049437 https://api.github.com/repos/pydata/xarray/issues/5881 IC_kwDOAMm_X844kVhd TomNicholas 35968931 2021-10-21T22:28:17Z 2021-10-21T22:28:17Z MEMBER

Hi @pmav99, thanks for raising this!

I would probably just fix it with

python diff --git a/xarray/backends/api.py b/xarray/backends/api.py index 6d73946b..00619d68 100644 --- a/xarray/backends/api.py +++ b/xarray/backends/api.py @@ -865,6 +865,8 @@ def open_mfdataset( ) else: paths = sorted(glob(_normalize_path(paths))) + elif isinstance(paths, Path): + paths = [str(paths)] else: paths = [str(p) if isinstance(p, Path) else p for p in paths] to emulate the list comprehension we already have.

Would you be interested in submitting this little fix as a PR? Or would you rather I did it?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `open_mfdataset` does not handle single `pathlib.Path` objects but handles single `str` just fine 1032233673

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);