home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

24 rows where author_association = "MEMBER", issue = 100646364 and user = 5356122 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • clarkfitzg · 24 ✖

issue 1

  • faceted plots · 24 ✖

author_association 1

  • MEMBER · 24 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
137870866 https://github.com/pydata/xarray/pull/527#issuecomment-137870866 https://api.github.com/repos/pydata/xarray/issues/527 MDEyOklzc3VlQ29tbWVudDEzNzg3MDg2Ng== clarkfitzg 5356122 2015-09-04T22:25:25Z 2015-09-04T22:25:25Z MEMBER

Ok, going to merge once the build passes. Will continue with the rest of the stuff next week. @shoyer should I rebase or squash these commits?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  faceted plots 100646364
137835422 https://github.com/pydata/xarray/pull/527#issuecomment-137835422 https://api.github.com/repos/pydata/xarray/issues/527 MDEyOklzc3VlQ29tbWVudDEzNzgzNTQyMg== clarkfitzg 5356122 2015-09-04T19:37:08Z 2015-09-04T19:37:08Z MEMBER

@shoyer Latest commit also added a little more to the docs on how to use the attributes data axes, and name_dicts.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  faceted plots 100646364
137588842 https://github.com/pydata/xarray/pull/527#issuecomment-137588842 https://api.github.com/repos/pydata/xarray/issues/527 MDEyOklzc3VlQ29tbWVudDEzNzU4ODg0Mg== clarkfitzg 5356122 2015-09-03T22:15:47Z 2015-09-03T22:15:47Z MEMBER

By the way, I believe this is to a point where we could easily tune any of the aesthetics- say shrinking the width of the colorbar or using a different number of ticks / sizes on the labels.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  faceted plots 100646364
137587792 https://github.com/pydata/xarray/pull/527#issuecomment-137587792 https://api.github.com/repos/pydata/xarray/issues/527 MDEyOklzc3VlQ29tbWVudDEzNzU4Nzc5Mg== clarkfitzg 5356122 2015-09-03T22:09:32Z 2015-09-03T22:09:32Z MEMBER

Here's what's left to do: - [ ] convenience method darray.plot(row='z') - [ ] map example using matplotlib quiver plot - [ ] port any more methods / features from Seaborn FacetGrid

@shoyer, am I forgetting anything?

Ready for this PR to be reviewed now. I can finish the rest in a follow up PR.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  faceted plots 100646364
131240388 https://github.com/pydata/xarray/pull/527#issuecomment-131240388 https://api.github.com/repos/pydata/xarray/issues/527 MDEyOklzc3VlQ29tbWVudDEzMTI0MDM4OA== clarkfitzg 5356122 2015-08-14T21:13:12Z 2015-09-03T21:57:53Z MEMBER

For this PR: - [x] facet on rows and columns - [x] Align label on colorbar - [x] Label figure axes - [x] Use xray plotting logic to make nice colorbar - [x] Make and test choices around colorbar

EDIT - going to revisit plt.contour(color='k') after #537 gets worked out. - [x] separate iteration over data from plotting - edge case: require the index to actually be unique .is_unique. - [x] Use core string formatting for titles - [x] tests for all of above - [x] test col_wrap - [x] write and organize docs - [x] docs for public attribute- axes and such

On this PR or possibly a different one: - [ ] Convenience method to easily make faceted plots- something like darray.plot(col='time') - [x] port Seaborn's aspect capabilities - [ ] matplotlib quiver plot for map example - [x] Create new xray.tutorial module with function like load_example_dataset for plotting examples

Different PR: - [ ] Facets and maps - [ ] Inline documentation and plots for API reference

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  faceted plots 100646364
137490299 https://github.com/pydata/xarray/pull/527#issuecomment-137490299 https://api.github.com/repos/pydata/xarray/issues/527 MDEyOklzc3VlQ29tbWVudDEzNzQ5MDI5OQ== clarkfitzg 5356122 2015-09-03T15:45:49Z 2015-09-03T15:45:49Z MEMBER

@shoyer multiple labels on x / y axes compared to the one above.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  faceted plots 100646364
137274951 https://github.com/pydata/xarray/pull/527#issuecomment-137274951 https://api.github.com/repos/pydata/xarray/issues/527 MDEyOklzc3VlQ29tbWVudDEzNzI3NDk1MQ== clarkfitzg 5356122 2015-09-02T23:45:56Z 2015-09-02T23:45:56Z MEMBER

Starting to agree with @shoyer and Seaborn on the multiple labels:

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  faceted plots 100646364
137273992 https://github.com/pydata/xarray/pull/527#issuecomment-137273992 https://api.github.com/repos/pydata/xarray/issues/527 MDEyOklzc3VlQ29tbWVudDEzNzI3Mzk5Mg== clarkfitzg 5356122 2015-09-02T23:37:56Z 2015-09-02T23:37:56Z MEMBER

Getting better...

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  faceted plots 100646364
137263395 https://github.com/pydata/xarray/pull/527#issuecomment-137263395 https://api.github.com/repos/pydata/xarray/issues/527 MDEyOklzc3VlQ29tbWVudDEzNzI2MzM5NQ== clarkfitzg 5356122 2015-09-02T22:30:03Z 2015-09-02T22:30:03Z MEMBER

Thanks for the encouragement @jhamman - I'll take what I can get! Seem to be finding a way around it by setting custom ax.xaxis.set_major_locator

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  faceted plots 100646364
137254992 https://github.com/pydata/xarray/pull/527#issuecomment-137254992 https://api.github.com/repos/pydata/xarray/issues/527 MDEyOklzc3VlQ29tbWVudDEzNzI1NDk5Mg== clarkfitzg 5356122 2015-09-02T21:52:22Z 2015-09-02T21:52:22Z MEMBER

Aaaaaaahhh!!

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  faceted plots 100646364
137237428 https://github.com/pydata/xarray/pull/527#issuecomment-137237428 https://api.github.com/repos/pydata/xarray/issues/527 MDEyOklzc3VlQ29tbWVudDEzNzIzNzQyOA== clarkfitzg 5356122 2015-09-02T20:37:51Z 2015-09-02T20:37:51Z MEMBER

Issues seem to be mostly caused by the colorbar.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  faceted plots 100646364
136885470 https://github.com/pydata/xarray/pull/527#issuecomment-136885470 https://api.github.com/repos/pydata/xarray/issues/527 MDEyOklzc3VlQ29tbWVudDEzNjg4NTQ3MA== clarkfitzg 5356122 2015-09-01T22:54:31Z 2015-09-01T22:54:31Z MEMBER

I believe it's possible to fix automatically. Somehow. Will look into it further tomorrow.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  faceted plots 100646364
136880349 https://github.com/pydata/xarray/pull/527#issuecomment-136880349 https://api.github.com/repos/pydata/xarray/issues/527 MDEyOklzc3VlQ29tbWVudDEzNjg4MDM0OQ== clarkfitzg 5356122 2015-09-01T22:22:35Z 2015-09-01T22:22:45Z MEMBER

For reference, here's what is happening once aspect is adjusted. x axes are all crowded.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  faceted plots 100646364
136878263 https://github.com/pydata/xarray/pull/527#issuecomment-136878263 https://api.github.com/repos/pydata/xarray/issues/527 MDEyOklzc3VlQ29tbWVudDEzNjg3ODI2Mw== clarkfitzg 5356122 2015-09-01T22:09:49Z 2015-09-01T22:09:49Z MEMBER

Some issues cropping up with using plt.tight_layout when manipulating the aspect and size.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  faceted plots 100646364
136527660 https://github.com/pydata/xarray/pull/527#issuecomment-136527660 https://api.github.com/repos/pydata/xarray/issues/527 MDEyOklzc3VlQ29tbWVudDEzNjUyNzY2MA== clarkfitzg 5356122 2015-08-31T23:34:11Z 2015-09-01T22:02:34Z MEMBER

take aspects and figure sizes from seaborn

Done

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  faceted plots 100646364
136525214 https://github.com/pydata/xarray/pull/527#issuecomment-136525214 https://api.github.com/repos/pydata/xarray/issues/527 MDEyOklzc3VlQ29tbWVudDEzNjUyNTIxNA== clarkfitzg 5356122 2015-08-31T23:15:30Z 2015-09-01T21:35:12Z MEMBER

add ability to set margin_titles=True.

TODO- don't really understand the use case for this.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  faceted plots 100646364
136849815 https://github.com/pydata/xarray/pull/527#issuecomment-136849815 https://api.github.com/repos/pydata/xarray/issues/527 MDEyOklzc3VlQ29tbWVudDEzNjg0OTgxNQ== clarkfitzg 5356122 2015-09-01T20:20:49Z 2015-09-01T20:20:49Z MEMBER

yep, could definitely do that. I'm still not crazy about repeating the x, y labels like that. Let me see if I can come up with a nice alternative using text on the figure.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  faceted plots 100646364
136847156 https://github.com/pydata/xarray/pull/527#issuecomment-136847156 https://api.github.com/repos/pydata/xarray/issues/527 MDEyOklzc3VlQ29tbWVudDEzNjg0NzE1Ng== clarkfitzg 5356122 2015-09-01T20:15:05Z 2015-09-01T20:15:05Z MEMBER

Here's what we have now with one missing block.

Not sure about these aesthetics.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  faceted plots 100646364
136523447 https://github.com/pydata/xarray/pull/527#issuecomment-136523447 https://api.github.com/repos/pydata/xarray/issues/527 MDEyOklzc3VlQ29tbWVudDEzNjUyMzQ0Nw== clarkfitzg 5356122 2015-08-31T23:03:43Z 2015-09-01T17:53:25Z MEMBER

todo- make sure to seed random number generator or else use deterministic

Done

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  faceted plots 100646364
136524437 https://github.com/pydata/xarray/pull/527#issuecomment-136524437 https://api.github.com/repos/pydata/xarray/issues/527 MDEyOklzc3VlQ29tbWVudDEzNjUyNDQzNw== clarkfitzg 5356122 2015-08-31T23:10:18Z 2015-08-31T23:10:18Z MEMBER

add matplotlib quiver plot for map example.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  faceted plots 100646364
135912898 https://github.com/pydata/xarray/pull/527#issuecomment-135912898 https://api.github.com/repos/pydata/xarray/issues/527 MDEyOklzc3VlQ29tbWVudDEzNTkxMjg5OA== clarkfitzg 5356122 2015-08-28T23:29:27Z 2015-08-28T23:29:27Z MEMBER

Here's where the progress stands:

g = xray.plot.FacetGrid(t5, col='time', col_wrap=2) g.map_dataarray(xray.plot.contour, color='k')

Looks like the column wrapping does the right thing by leaving the last axes blank.

Observe #537 is still an issue here. We'll have to make sure that when that is fixed it also works for these facets.

On Monday morning I can clean the code up, take out the seaborn chunks, reorganize the docs, and then I'll be ready to ask for a review.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  faceted plots 100646364
131173521 https://github.com/pydata/xarray/pull/527#issuecomment-131173521 https://api.github.com/repos/pydata/xarray/issues/527 MDEyOklzc3VlQ29tbWVudDEzMTE3MzUyMQ== clarkfitzg 5356122 2015-08-14T16:37:28Z 2015-08-14T16:37:28Z MEMBER

Thanks! The colorbar label spacing is a matplotlib thing- it only became a problem after rotating it to match the row labels. So I expect that I can fix it by changing the anchor point or placing it manually.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  faceted plots 100646364
130903866 https://github.com/pydata/xarray/pull/527#issuecomment-130903866 https://api.github.com/repos/pydata/xarray/issues/527 MDEyOklzc3VlQ29tbWVudDEzMDkwMzg2Ng== clarkfitzg 5356122 2015-08-14T00:47:54Z 2015-08-14T00:47:54Z MEMBER

Here's what a 4d array looks like.

``` In [26]: t4d = xray.concat([t2, t2 + 50], pd.Index(['normal', 'hot'], name='fourth_dim'))

This is a 4d array

In [27]: t4d.coords Out[27]: Coordinates: * lat (lat) float32 75.0 72.5 70.0 67.5 65.0 62.5 60.0 57.5 55.0 ... * lon (lon) float32 200.0 202.5 205.0 207.5 210.0 212.5 215.0 ... * time (time) datetime64[ns] 2013-01-01 2013-03-04T12:00:00 * fourth_dim (fourth_dim) object 'normal' 'hot'

In [28]: g = xray.plot.FacetGrid(t4d, col='time', row='fourth_dim')

In [29]: g.map_dataarray(xray.plot.imshow, 'lon', 'lat') Out[29]: <xray.plot.facetgrid.FacetGrid at 0x10f5aad90> ```

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  faceted plots 100646364
130766241 https://github.com/pydata/xarray/pull/527#issuecomment-130766241 https://api.github.com/repos/pydata/xarray/issues/527 MDEyOklzc3VlQ29tbWVudDEzMDc2NjI0MQ== clarkfitzg 5356122 2015-08-13T17:17:05Z 2015-08-13T17:17:05Z MEMBER

@shoyer Here's what we currently have:

``` In [15]: g = xray.plot.FacetGrid(t, col='time', col_wrap=2)

In [16]: g.map_dataarray(xray.plot.contourf, 'lon', 'lat') Out[16]: <xray.plot.facetgrid.FacetGrid at 0x10de082d0> ```

Right now this assumes that the function for map_dataarray has the same signature as 2d xray plotting methods.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  faceted plots 100646364

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 18.058ms · About: xarray-datasette