issue_comments

Table actions

7 rows where author_association = "CONTRIBUTOR", issue = 945434599 and user = 76039838 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • pkopparla · 7 ✖

issue 1

  • Kwargs to rasterio open · 7 ✖

author_association 1

  • CONTRIBUTOR · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
889686492 https://github.com/pydata/xarray/pull/5609#issuecomment-889686492 https://api.github.com/repos/pydata/xarray/issues/5609 IC_kwDOAMm_X841B4nc pkopparla 76039838 2021-07-30T07:19:19Z 2021-07-30T07:19:19Z CONTRIBUTOR

Thanks for leading me through the process @keewis , it's my first code contribution to any open-source project. Hope to do more in the future.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599
887356235 https://github.com/pydata/xarray/pull/5609#issuecomment-887356235 https://api.github.com/repos/pydata/xarray/issues/5609 IC_kwDOAMm_X8404_tL pkopparla 76039838 2021-07-27T09:24:10Z 2021-07-27T09:24:10Z CONTRIBUTOR

@keewis Done!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599
887305146 https://github.com/pydata/xarray/pull/5609#issuecomment-887305146 https://api.github.com/repos/pydata/xarray/issues/5609 IC_kwDOAMm_X8404zO6 pkopparla 76039838 2021-07-27T08:09:27Z 2021-07-27T08:10:14Z CONTRIBUTOR

@keewis thanks! Looks like most checks are successful now. Is there anything further I should do? Should I close the pull request?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599
887282590 https://github.com/pydata/xarray/pull/5609#issuecomment-887282590 https://api.github.com/repos/pydata/xarray/issues/5609 IC_kwDOAMm_X8404tue pkopparla 76039838 2021-07-27T07:33:27Z 2021-07-27T07:33:27Z CONTRIBUTOR

@dcherian @keewis Hey guys, a backend test is failing but I'm not sure why or how my change is affecting it. Would be grateful for a pointer.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599
881283746 https://github.com/pydata/xarray/pull/5609#issuecomment-881283746 https://api.github.com/repos/pydata/xarray/issues/5609 IC_kwDOAMm_X840h1Ki pkopparla 76039838 2021-07-16T08:47:00Z 2021-07-16T08:47:00Z CONTRIBUTOR

Looks like the backend_kwargs argument is breaking the function. Should I just get rid of it and leave in **kwargs?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599
881233598 https://github.com/pydata/xarray/pull/5609#issuecomment-881233598 https://api.github.com/repos/pydata/xarray/issues/5609 IC_kwDOAMm_X840ho6- pkopparla 76039838 2021-07-16T07:19:24Z 2021-07-16T07:19:24Z CONTRIBUTOR

Thanks everyone for the feedback. I've added a backend_kwargs and a **kwargs argument following the xarray.open_dataset style.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599
880800433 https://github.com/pydata/xarray/pull/5609#issuecomment-880800433 https://api.github.com/repos/pydata/xarray/issues/5609 MDEyOklzc3VlQ29tbWVudDg4MDgwMDQzMw== pkopparla 76039838 2021-07-15T15:39:04Z 2021-07-15T15:44:10Z CONTRIBUTOR

Should this pass **kwargs through rather than take an explicit kwargs arg?

I am not sure about the nuances here, but the linked issue shows a h5netcdf function that follows the same pattern.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Kwargs to rasterio open 945434599

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);