issue_comments

Table actions

5 rows where author_association = "CONTRIBUTOR", issue = 381518663 and user = 4687996 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • phausamann · 5 ✖

issue 1

  • Add transpose_coords option to DataArray.transpose · 5 ✖

author_association 1

  • CONTRIBUTOR · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
494478111 https://github.com/pydata/xarray/pull/2556#issuecomment-494478111 https://api.github.com/repos/pydata/xarray/issues/2556 MDEyOklzc3VlQ29tbWVudDQ5NDQ3ODExMQ== phausamann 4687996 2019-05-21T17:10:59Z 2019-05-21T17:10:59Z CONTRIBUTOR

Looks like the build failures were only temporary, all the checks are passing now. I think this is good to go.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add transpose_coords option to DataArray.transpose 381518663
476281443 https://github.com/pydata/xarray/pull/2556#issuecomment-476281443 https://api.github.com/repos/pydata/xarray/issues/2556 MDEyOklzc3VlQ29tbWVudDQ3NjI4MTQ0Mw== phausamann 4687996 2019-03-25T16:41:32Z 2019-03-25T16:41:32Z CONTRIBUTOR

@shoyer is this ready to be merged?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add transpose_coords option to DataArray.transpose 381518663
470940357 https://github.com/pydata/xarray/pull/2556#issuecomment-470940357 https://api.github.com/repos/pydata/xarray/issues/2556 MDEyOklzc3VlQ29tbWVudDQ3MDk0MDM1Nw== phausamann 4687996 2019-03-08T14:08:46Z 2019-03-08T14:08:46Z CONTRIBUTOR

I've added a restore_coord_dims parameter to groupby, groupby_bins and resample and eliminated all warnings from the tests. The build failure seems to be inherited from the master branch.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add transpose_coords option to DataArray.transpose 381518663
441019330 https://github.com/pydata/xarray/pull/2556#issuecomment-441019330 https://api.github.com/repos/pydata/xarray/issues/2556 MDEyOklzc3VlQ29tbWVudDQ0MTAxOTMzMA== phausamann 4687996 2018-11-22T12:42:59Z 2018-11-22T12:43:34Z CONTRIBUTOR

I've changed all the transpose calls in the tests to transpose_coords=True. Other than that, there's some transpose calls in plot and groupby that I've updated, but I'm not sure whether they should be True, False or not updated at all (see above).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add transpose_coords option to DataArray.transpose 381518663
439918296 https://github.com/pydata/xarray/pull/2556#issuecomment-439918296 https://api.github.com/repos/pydata/xarray/issues/2556 MDEyOklzc3VlQ29tbWVudDQzOTkxODI5Ng== phausamann 4687996 2018-11-19T14:50:30Z 2018-11-19T14:50:30Z CONTRIBUTOR

I've updated the method to issue the warning and fixed the failing tests (which was actually a bug in my implementation).

It would be fine to use transpose_coords=False explicitly in tests, but we should silence all warnings.

I'm not exactly sure how this works, there are a lot of tests where the warning is issued, especially calls to DataArray.T. Should I update all of these tests to transpose(..., transpose_coords=False)?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add transpose_coords option to DataArray.transpose 381518663

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);