issue_comments

Table actions

9 rows where author_association = "CONTRIBUTOR", issue = 354324342 and user = 4806877 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • jsignell · 9 ✖

issue 1

  • Adding data kwarg to copy to create new objects with same structure as original · 9 ✖

author_association 1

  • CONTRIBUTOR · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
422457576 https://github.com/pydata/xarray/pull/2384#issuecomment-422457576 https://api.github.com/repos/pydata/xarray/issues/2384 MDEyOklzc3VlQ29tbWVudDQyMjQ1NzU3Ng== jsignell 4806877 2018-09-18T16:19:30Z 2018-09-18T16:19:30Z CONTRIBUTOR

Is this good to go?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding data kwarg to copy to create new objects with same structure as original 354324342
421407370 https://github.com/pydata/xarray/pull/2384#issuecomment-421407370 https://api.github.com/repos/pydata/xarray/issues/2384 MDEyOklzc3VlQ29tbWVudDQyMTQwNzM3MA== jsignell 4806877 2018-09-14T16:09:54Z 2018-09-14T16:09:54Z CONTRIBUTOR

I added some examples on copy for each of the object types and I decided to let Datasets do this too. I just require that the user pass a dict where keys are contained in data_vars and each value has the same shape as the corresponding data_var.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding data kwarg to copy to create new objects with same structure as original 354324342
420626485 https://github.com/pydata/xarray/pull/2384#issuecomment-420626485 https://api.github.com/repos/pydata/xarray/issues/2384 MDEyOklzc3VlQ29tbWVudDQyMDYyNjQ4NQ== jsignell 4806877 2018-09-12T12:16:00Z 2018-09-12T12:16:00Z CONTRIBUTOR

I made the docs changes and added an example. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding data kwarg to copy to create new objects with same structure as original 354324342
420393391 https://github.com/pydata/xarray/pull/2384#issuecomment-420393391 https://api.github.com/repos/pydata/xarray/issues/2384 MDEyOklzc3VlQ29tbWVudDQyMDM5MzM5MQ== jsignell 4806877 2018-09-11T19:26:42Z 2018-09-11T19:26:42Z CONTRIBUTOR

I think this is good to merge

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding data kwarg to copy to create new objects with same structure as original 354324342
419486238 https://github.com/pydata/xarray/pull/2384#issuecomment-419486238 https://api.github.com/repos/pydata/xarray/issues/2384 MDEyOklzc3VlQ29tbWVudDQxOTQ4NjIzOA== jsignell 4806877 2018-09-07T16:01:31Z 2018-09-07T16:01:31Z CONTRIBUTOR

👍 for xarray.structured_like(new_data, template)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding data kwarg to copy to create new objects with same structure as original 354324342
419478223 https://github.com/pydata/xarray/pull/2384#issuecomment-419478223 https://api.github.com/repos/pydata/xarray/issues/2384 MDEyOklzc3VlQ29tbWVudDQxOTQ3ODIyMw== jsignell 4806877 2018-09-07T15:34:52Z 2018-09-07T15:34:52Z CONTRIBUTOR

That said. I think with_data is better than anything replace. I would worry about confusion with the pandas replace which replaces specific values. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding data kwarg to copy to create new objects with same structure as original 354324342
419477495 https://github.com/pydata/xarray/pull/2384#issuecomment-419477495 https://api.github.com/repos/pydata/xarray/issues/2384 MDEyOklzc3VlQ29tbWVudDQxOTQ3NzQ5NQ== jsignell 4806877 2018-09-07T15:32:22Z 2018-09-07T15:32:22Z CONTRIBUTOR

I don't like it being a method on an existing object. I think the syntax is clearer if the template object is an argument and the second argument is the data. I think that conveys the concept of creating a new object that is just using the structure of another object.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding data kwarg to copy to create new objects with same structure as original 354324342
419472466 https://github.com/pydata/xarray/pull/2384#issuecomment-419472466 https://api.github.com/repos/pydata/xarray/issues/2384 MDEyOklzc3VlQ29tbWVudDQxOTQ3MjQ2Ng== jsignell 4806877 2018-09-07T15:16:47Z 2018-09-07T15:16:47Z CONTRIBUTOR

Or what about xr.DataArray.like and xr.Variable.like? My main worry is that it kind of feels like these should return bools. Another option would be xr.DataArray.from_dataarray and xr.Variable.from_variable, but that is maybe also confusing...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding data kwarg to copy to create new objects with same structure as original 354324342
419082605 https://github.com/pydata/xarray/pull/2384#issuecomment-419082605 https://api.github.com/repos/pydata/xarray/issues/2384 MDEyOklzc3VlQ29tbWVudDQxOTA4MjYwNQ== jsignell 4806877 2018-09-06T12:55:37Z 2018-09-06T12:55:37Z CONTRIBUTOR

Any thoughts on this one?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Adding data kwarg to copy to create new objects with same structure as original 354324342

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);