issue_comments

Table actions

3 rows where author_association = "CONTRIBUTOR", issue = 312693611 and user = 13837821 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • dnowacki-usgs · 3 ✖

issue 1

  • Implement setncattr_string for attributes that are lists of strings · 3 ✖

author_association 1

  • CONTRIBUTOR · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
381742272 https://github.com/pydata/xarray/pull/2045#issuecomment-381742272 https://api.github.com/repos/pydata/xarray/issues/2045 MDEyOklzc3VlQ29tbWVudDM4MTc0MjI3Mg== dnowacki-usgs 13837821 2018-04-16T20:42:01Z 2018-04-16T20:42:01Z CONTRIBUTOR

@shoyer Thank you for the helpful feedback. I think I addressed all of your comments, and also expanded the tests.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement setncattr_string for attributes that are lists of strings 312693611
380239938 https://github.com/pydata/xarray/pull/2045#issuecomment-380239938 https://api.github.com/repos/pydata/xarray/issues/2045 MDEyOklzc3VlQ29tbWVudDM4MDIzOTkzOA== dnowacki-usgs 13837821 2018-04-10T20:42:34Z 2018-04-10T20:42:34Z CONTRIBUTOR

I only have a vague grasp of proper object oriented programming practices; not sure if the helper functions should be within the class or what, but it does seem to work this way.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement setncattr_string for attributes that are lists of strings 312693611
380156622 https://github.com/pydata/xarray/pull/2045#issuecomment-380156622 https://api.github.com/repos/pydata/xarray/issues/2045 MDEyOklzc3VlQ29tbWVudDM4MDE1NjYyMg== dnowacki-usgs 13837821 2018-04-10T16:05:48Z 2018-04-10T16:05:48Z CONTRIBUTOR

OK, after some false starts, I think this is working, but the CI build is failing on CONDA_ENV=py35 and py36... but it's failing on a different test (specific to netcdf3, complaining about a temp file) and I can't see how it is impacted by my changes... thoughts?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Implement setncattr_string for attributes that are lists of strings 312693611

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);