issue_comments

Table actions

6 rows where author_association = "CONTRIBUTOR", issue = 293830986 and user = 1964655 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • ghisvail · 6 ✖

issue 1

  • Explicit listing of optional dependencies · 6 ✖

author_association 1

  • CONTRIBUTOR · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
362793230 https://github.com/pydata/xarray/issues/1879#issuecomment-362793230 https://api.github.com/repos/pydata/xarray/issues/1879 MDEyOklzc3VlQ29tbWVudDM2Mjc5MzIzMA== ghisvail 1964655 2018-02-03T09:24:19Z 2018-02-03T09:24:19Z CONTRIBUTOR

I guess that by your definition it would be suggested?

Correct.

Is rasterio going to make it to debian as an apt package?

That's already the case, see: https://packages.debian.org/source/sid/rasterio

What about toolz used by auto_combine?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Explicit listing of optional dependencies 293830986
362712709 https://github.com/pydata/xarray/issues/1879#issuecomment-362712709 https://api.github.com/repos/pydata/xarray/issues/1879 MDEyOklzc3VlQ29tbWVudDM2MjcxMjcwOQ== ghisvail 1964655 2018-02-02T21:27:40Z 2018-02-02T21:27:40Z CONTRIBUTOR

Well, I am considering (perhaps wrongly) what's in xarray/__init__.py as the public API of xarray. With that logic in mind, any unconditional import should be treated as an install dependency. Otherwise, users will indeed get an ImportError which is not very good.

Back to the original topic, should toolz and rasterio be strict dependencies, recommended or suggested then?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Explicit listing of optional dependencies 293830986
362709426 https://github.com/pydata/xarray/issues/1879#issuecomment-362709426 https://api.github.com/repos/pydata/xarray/issues/1879 MDEyOklzc3VlQ29tbWVudDM2MjcwOTQyNg== ghisvail 1964655 2018-02-02T21:14:13Z 2018-02-02T21:14:13Z CONTRIBUTOR

And open_rasterio is also exposed by xarray/__init__.py and imports rasterio unconditionally. So again, that makes rasterio an install_requires too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Explicit listing of optional dependencies 293830986
362708442 https://github.com/pydata/xarray/issues/1879#issuecomment-362708442 https://api.github.com/repos/pydata/xarray/issues/1879 MDEyOklzc3VlQ29tbWVudDM2MjcwODQ0Mg== ghisvail 1964655 2018-02-02T21:10:27Z 2018-02-02T21:10:27Z CONTRIBUTOR

Indeed. xarray/__init__.py does import auto_combine from xarray/core/combine.py, so toolz should be listed as install_depends I guess.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Explicit listing of optional dependencies 293830986
362707544 https://github.com/pydata/xarray/issues/1879#issuecomment-362707544 https://api.github.com/repos/pydata/xarray/issues/1879 MDEyOklzc3VlQ29tbWVudDM2MjcwNzU0NA== ghisvail 1964655 2018-02-02T21:06:49Z 2018-02-02T21:06:49Z CONTRIBUTOR

And what about toolz which is used in xarray/core/combine.py?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Explicit listing of optional dependencies 293830986
362705948 https://github.com/pydata/xarray/issues/1879#issuecomment-362705948 https://api.github.com/repos/pydata/xarray/issues/1879 MDEyOklzc3VlQ29tbWVudDM2MjcwNTk0OA== ghisvail 1964655 2018-02-02T21:00:25Z 2018-02-02T21:00:25Z CONTRIBUTOR

So, just to confirm, the recommended dependencies are just dask, netCDF4 and bottleneck, right? The rest should be suggested.

What about cyordereddict? It is listed in the docs but its description says it is obsolete.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Explicit listing of optional dependencies 293830986

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);