issue_comments

Table actions

2 rows where author_association = "CONTRIBUTOR", issue = 289853579 and user = 12229877 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • Zac-HD · 2 ✖

issue 1

  • Read small integers as float32, not float64 · 2 ✖

author_association 1

  • CONTRIBUTOR · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
359168533 https://github.com/pydata/xarray/pull/1840#issuecomment-359168533 https://api.github.com/repos/pydata/xarray/issues/1840 MDEyOklzc3VlQ29tbWVudDM1OTE2ODUzMw== Zac-HD 12229877 2018-01-20T12:39:30Z 2018-01-20T12:39:30Z CONTRIBUTOR

Added tests; float32 not upcast, float16 ("intended for storage of many floating-point values where higher precision is not needed, not for performing arithmetic") is upcast but only to float32.

I'll open a new issue to add a basic suite of property-based tests to Xarray 😄

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Read small integers as float32, not float64 289853579
358882878 https://github.com/pydata/xarray/pull/1840#issuecomment-358882878 https://api.github.com/repos/pydata/xarray/issues/1840 MDEyOklzc3VlQ29tbWVudDM1ODg4Mjg3OA== Zac-HD 12229877 2018-01-19T06:58:14Z 2018-01-19T06:58:14Z CONTRIBUTOR

Thanks - I was actually writing up an issue and decided it would be easier to demonstrate the proposed fix in a PR, but I'll open an issue first next time.

The checkbox about flake8 could be removed from the issue template now - since #1824 we run flake8 on everything in CI so if tests pass flake8 is passing too.

Re: tests: what do you (and @shoyer) think about using Hypothesis for some property-based tests of variable coding? "encoding then decoding is a no-op" is a classic property 😄 Upside, more powerful and better at finding edge cases; downside slower simply because it checks more cases (a configurable number).

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Read small integers as float32, not float64 289853579

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);