issue_comments

Table actions

3 rows where author_association = "CONTRIBUTOR", issue = 285006452 and user = 3698640 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • delgadom · 3 ✖

issue 1

  • Handle _FillValue in variable-length unicode string variables · 3 ✖

author_association 1

  • CONTRIBUTOR · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
354469859 https://github.com/pydata/xarray/pull/1802#issuecomment-354469859 https://api.github.com/repos/pydata/xarray/issues/1802 MDEyOklzc3VlQ29tbWVudDM1NDQ2OTg1OQ== delgadom 3698640 2017-12-29T16:45:37Z 2017-12-29T16:45:37Z CONTRIBUTOR

Ok this is good to go if you all do want to enable _FillValue for variable-length unicode strings with a netCDF4 backend. Seems like there's a lot of prior work/thinking in this space though so no worries if you want to wait.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle _FillValue in variable-length unicode string variables 285006452
354379246 https://github.com/pydata/xarray/pull/1802#issuecomment-354379246 https://api.github.com/repos/pydata/xarray/issues/1802 MDEyOklzc3VlQ29tbWVudDM1NDM3OTI0Ng== delgadom 3698640 2017-12-29T00:22:57Z 2017-12-29T00:22:57Z CONTRIBUTOR

lol. no I'm just walking around in your footsteps @shoyer. I've just enabled the tests you presumably wrote for #1647 & #1648. Curious why variable-length unicode strings with _FillHoles using netCDF4 doesn't currently work in master?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle _FillValue in variable-length unicode string variables 285006452
354378158 https://github.com/pydata/xarray/pull/1802#issuecomment-354378158 https://api.github.com/repos/pydata/xarray/issues/1802 MDEyOklzc3VlQ29tbWVudDM1NDM3ODE1OA== delgadom 3698640 2017-12-29T00:11:53Z 2017-12-29T00:11:53Z CONTRIBUTOR

hmm. Seems I'm touching on a much larger issue here: Unidata/netcdf4-python#730

The round-trip works for me using a netcdf4 engine once this fix is implemented in conventions.py. There are tests that are ready to demonstrate this in test_backends.py:836-843, but running these tests (by removing the pytest.raises lines) applies to both netCDF4 and h5netcdf backends.

Should these use cases be split up?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Handle _FillValue in variable-length unicode string variables 285006452

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);