issue_comments

Table actions

2 rows where author_association = "CONTRIBUTOR", issue = 258884482 and user = 6200806 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • spencerahill · 2 ✖

issue 1

  • data_vars option added to open_mfdataset · 2 ✖

author_association 1

  • CONTRIBUTOR · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
330672462 https://github.com/pydata/xarray/pull/1580#issuecomment-330672462 https://api.github.com/repos/pydata/xarray/issues/1580 MDEyOklzc3VlQ29tbWVudDMzMDY3MjQ2Mg== spencerahill 6200806 2017-09-19T21:01:55Z 2017-09-19T21:01:55Z CONTRIBUTOR

Try running them via pytest instead (pip install pytest or conda install pytest if you don't have it already).

Note that you'll need to add new test(s) that cover the modifications you have made -- not just run the existing tests. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   data_vars option added to open_mfdataset 258884482
330648836 https://github.com/pydata/xarray/pull/1580#issuecomment-330648836 https://api.github.com/repos/pydata/xarray/issues/1580 MDEyOklzc3VlQ29tbWVudDMzMDY0ODgzNg== spencerahill 6200806 2017-09-19T19:31:00Z 2017-09-19T19:32:31Z CONTRIBUTOR

have not run tests yet

These will definitely be needed. Existing tests for open_mfdataset are in xarray/tests/test_backends.py. @shoyer and/or @jhamman can hopefully help you out if you need more guidance.

Not sure how to install flake8

pip install flake8 should work. Alternatively if you use conda conda install -c conda-forge flake8

Do not think the change is big enough to be added to the files

A brief note in What's New under the Enhancements section would actually be appropriate. Just follow the example of the others in that section.

Thanks for taking this on! We actually just bumped across this (here), so your fix will immediately benefit more than just you.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   data_vars option added to open_mfdataset 258884482

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);