issue_comments

Table actions

2 rows where author_association = "CONTRIBUTOR", issue = 230529125 and user = 5572303 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • chunweiyuan · 2 ✖

issue 1

  • .equals() on a coordinate takes attributes into comparison · 2 ✖

author_association 1

  • CONTRIBUTOR · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
303255121 https://github.com/pydata/xarray/issues/1420#issuecomment-303255121 https://api.github.com/repos/pydata/xarray/issues/1420 MDEyOklzc3VlQ29tbWVudDMwMzI1NTEyMQ== chunweiyuan 5572303 2017-05-23T00:21:29Z 2017-05-23T00:21:29Z CONTRIBUTOR

This is getting close to the fundamental paradigm of xarray. Would it entail some massive code migration (and user protests) if we change how we express da.coords['x'](by removing point coordinates)?

I'm thinking of a new API that compares only the values and indexing coordinates between two objects, but struggle to come up with a simple, descriptive name........

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   .equals() on a coordinate takes attributes into comparison 230529125
303244294 https://github.com/pydata/xarray/issues/1420#issuecomment-303244294 https://api.github.com/repos/pydata/xarray/issues/1420 MDEyOklzc3VlQ29tbWVudDMwMzI0NDI5NA== chunweiyuan 5572303 2017-05-22T23:09:39Z 2017-05-22T23:09:39Z CONTRIBUTOR

I'm just having a hard time wrapping my head around the definitions here. da['some_attr'] = 0 sets a point coordinate, and this point coordinate shows up in da.coords, but not da.dims, because da.dims only pertains to indexing coordinates. Why is this point coordinate attached to every other coordinate then? In other words, why would da.coords['x'] contain some_attr as well?

Somehow it just doesn't feel right intuitively for some point dimension to mess up my comparison between two 1-D coordinates, but I might be missing some important use cases here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   .equals() on a coordinate takes attributes into comparison 230529125

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);