issue_comments

Table actions

4 rows where author_association = "CONTRIBUTOR", issue = 1183534905 and user = 22245117 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • malmans2 · 4 ✖

issue 1

  • Add support in the "zarr" backend for reading NCZarr data · 4 ✖

author_association 1

  • CONTRIBUTOR · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1094221271 https://github.com/pydata/xarray/pull/6420#issuecomment-1094221271 https://api.github.com/repos/pydata/xarray/issues/6420 IC_kwDOAMm_X85BOH3X malmans2 22245117 2022-04-10T08:49:07Z 2022-04-10T08:49:07Z CONTRIBUTOR

Could you also add brief updates to mention NCZarr support in the docstring for open_zarr and the user guide? In particular this paragraph should be updated:

Xarray can’t open just any zarr dataset, because xarray requires special metadata (attributes) describing the dataset dimensions and coordinates. At this time, xarray can only open zarr datasets that have been written by xarray. For implementation details, see Zarr Encoding Specification.

Documentation should be in good shape now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add support in the "zarr" backend for reading NCZarr data 1183534905
1093846662 https://github.com/pydata/xarray/pull/6420#issuecomment-1093846662 https://api.github.com/repos/pydata/xarray/issues/6420 IC_kwDOAMm_X85BMsaG malmans2 22245117 2022-04-09T10:04:21Z 2022-04-09T10:04:21Z CONTRIBUTOR

Thanks for the review @shoyer! This should be good to go now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add support in the "zarr" backend for reading NCZarr data 1183534905
1091147424 https://github.com/pydata/xarray/pull/6420#issuecomment-1091147424 https://api.github.com/repos/pydata/xarray/issues/6420 IC_kwDOAMm_X85BCZag malmans2 22245117 2022-04-07T06:56:41Z 2022-04-07T06:56:41Z CONTRIBUTOR

The code now looks for NCZarr attributes if both of the following conditions are True: - _ARRAY_DIMENSIONS is missing - we are NOT in mode a or r+. As we don't write NCZarr attributes, this prevents from creating zarr using a mix of NCZarr and Xarray conventions.

I'm not sure what's the best approach with _NC* attributes. Currently, after reading the metadata useful to xarray, they are hidden or dropped. This is somewhat related to #6448.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add support in the "zarr" backend for reading NCZarr data 1183534905
1081134778 https://github.com/pydata/xarray/pull/6420#issuecomment-1081134778 https://api.github.com/repos/pydata/xarray/issues/6420 IC_kwDOAMm_X85AcM66 malmans2 22245117 2022-03-28T20:55:45Z 2022-03-28T20:55:45Z CONTRIBUTOR

The errors on Windows appear to be related to the fill_value written by the "netcdf4" backend in ".zattrs", so probably needs to be addressed in netcdf4-python or netcdf-c. The fill_value is Nan rather than NaN.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add support in the "zarr" backend for reading NCZarr data 1183534905

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);