issue_comments

Table actions

3 rows where author_association = "COLLABORATOR", issue = 922926807 and user = 43316012 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • headtr1ck · 3 ✖

issue 1

  • Fix issue tuple as dimension · 3 ✖

author_association 1

  • COLLABORATOR · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1323755762 https://github.com/pydata/xarray/pull/5477#issuecomment-1323755762 https://api.github.com/repos/pydata/xarray/issues/5477 IC_kwDOAMm_X85O5ujy headtr1ck 43316012 2022-11-22T14:22:33Z 2022-11-22T14:22:33Z COLLABORATOR

Yes exactly, that would be the intended way of working with dimensions/variables that are iterablea themself, like tuples.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix issue tuple as dimension 922926807
1323694111 https://github.com/pydata/xarray/pull/5477#issuecomment-1323694111 https://api.github.com/repos/pydata/xarray/issues/5477 IC_kwDOAMm_X85O5fgf headtr1ck 43316012 2022-11-22T13:39:11Z 2022-11-22T13:39:11Z COLLABORATOR

So we'd keep str | Iterable[Hashable], and still raise an error if a tuple was passed directly (i.e. method(dim=('a','b'))

I would say that a tuple is fine, it IS an iterable of hashable ;)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix issue tuple as dimension 922926807
1322745490 https://github.com/pydata/xarray/pull/5477#issuecomment-1322745490 https://api.github.com/repos/pydata/xarray/issues/5477 IC_kwDOAMm_X85O136S headtr1ck 43316012 2022-11-21T22:37:09Z 2022-11-21T22:37:09Z COLLABORATOR

I think this should be also aligned with str | Iterable[Hashable], so maybe str | DataArray | Iterable[Hashable | DataArray]? And then reverse the isinstance checks (do not capture tuple and list explicitly, but str).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix issue tuple as dimension 922926807

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);