issue_comments

Table actions

3 rows where author_association = "COLLABORATOR", issue = 1730664352 and user = 43316012 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • headtr1ck · 3 ✖

issue 1

  • don't use `CacheFileManager.__del__` on interpreter shutdown · 3 ✖

author_association 1

  • COLLABORATOR · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1572359754 https://github.com/pydata/xarray/pull/7880#issuecomment-1572359754 https://api.github.com/repos/pydata/xarray/issues/7880 IC_kwDOAMm_X85duE5K headtr1ck 43316012 2023-06-01T16:23:45Z 2023-06-01T16:23:45Z COLLABORATOR

Maybe you can add a test that creates a cachingFilemanager object, then deletes it, then run gc.collect() and check somehow if it works? But no idea how pytest interferes with this or how you can ensure that there are no references to the module anymore?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   don't use `CacheFileManager.__del__` on interpreter shutdown 1730664352
1567450094 https://github.com/pydata/xarray/pull/7880#issuecomment-1567450094 https://api.github.com/repos/pydata/xarray/issues/7880 IC_kwDOAMm_X85dbWPu headtr1ck 43316012 2023-05-29T19:28:21Z 2023-05-29T19:28:21Z COLLABORATOR

I think this is intended (though certainly not very easy to get right): see the second part of the warning in the __del__ documentation.

You are right, that warning is exactly what is causing the issues.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   don't use `CacheFileManager.__del__` on interpreter shutdown 1730664352
1567439206 https://github.com/pydata/xarray/pull/7880#issuecomment-1567439206 https://api.github.com/repos/pydata/xarray/issues/7880 IC_kwDOAMm_X85dbTlm headtr1ck 43316012 2023-05-29T19:09:41Z 2023-05-29T19:09:41Z COLLABORATOR

That's quite a weird bug. I would have thought that the global (or module level here) variable/function aquire should have at least one reference until after the deletion of the object. Is that a bug in pythons garbage collection?

Or does the garbage collection already start when calling del and does not wait for the completion of the __del__ method?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   don't use `CacheFileManager.__del__` on interpreter shutdown 1730664352

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);