issue_comments

Table actions

7 rows where author_association = "COLLABORATOR" and issue = 1580266844 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

issue 1

  • use numpys SupportsDtype · 7 ✖

author_association 1

  • COLLABORATOR · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1474861240 https://github.com/pydata/xarray/pull/7521#issuecomment-1474861240 https://api.github.com/repos/pydata/xarray/issues/7521 IC_kwDOAMm_X85X6Ji4 headtr1ck 43316012 2023-03-18T14:08:20Z 2023-03-18T14:08:20Z COLLABORATOR

I guess we should revert this change and use our own definition as proposed by the numpy defs. If I find time I'll make a new PR such that we can be independent off numpys version in this regard.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   use numpys SupportsDtype 1580266844
1462773338 https://github.com/pydata/xarray/pull/7521#issuecomment-1462773338 https://api.github.com/repos/pydata/xarray/issues/7521 IC_kwDOAMm_X85XMCZa headtr1ck 43316012 2023-03-09T20:44:04Z 2023-03-09T20:44:04Z COLLABORATOR

It seems that numpy is somewhat against this change, so maybe we are better off to restore the previous state to not have a mess with supporting different numpy versions again. Lets keep that in mind before the next release but wait if something changes on numpys side.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   use numpys SupportsDtype 1580266844
1450819830 https://github.com/pydata/xarray/pull/7521#issuecomment-1450819830 https://api.github.com/repos/pydata/xarray/issues/7521 IC_kwDOAMm_X85WecD2 headtr1ck 43316012 2023-03-01T20:44:52Z 2023-03-01T20:44:52Z COLLABORATOR

I have opened https://github.com/numpy/numpy/issues/23308

It should be an easy change on numpys side if they decide to go for it. Only problem, we again have to special case this based on bumpy version, haha.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   use numpys SupportsDtype 1580266844
1449428744 https://github.com/pydata/xarray/pull/7521#issuecomment-1449428744 https://api.github.com/repos/pydata/xarray/issues/7521 IC_kwDOAMm_X85WZIcI headtr1ck 43316012 2023-03-01T06:31:46Z 2023-03-01T06:31:46Z COLLABORATOR

Do you know if there's a plan to make something like this public on the numpy end?

No idea, the static typing of numpy is still changing a lot and has many bugs (same with xarray, haha).

I'm sure they will make it public is we request it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   use numpys SupportsDtype 1580266844
1426820348 https://github.com/pydata/xarray/pull/7521#issuecomment-1426820348 https://api.github.com/repos/pydata/xarray/issues/7521 IC_kwDOAMm_X85VC4z8 headtr1ck 43316012 2023-02-11T16:46:31Z 2023-02-12T14:17:33Z COLLABORATOR

Is it some caching issue, since this PR has been lying around for some time? Edit: nvmd, haha. I just created it literally yesterday.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   use numpys SupportsDtype 1580266844
1426818186 https://github.com/pydata/xarray/pull/7521#issuecomment-1426818186 https://api.github.com/repos/pydata/xarray/issues/7521 IC_kwDOAMm_X85VC4SK headtr1ck 43316012 2023-02-11T16:38:20Z 2023-02-11T16:38:20Z COLLABORATOR

I vaguely remember seeing this error before, but no idea how it got fixed. Maybe this run uses an older version of distributed?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   use numpys SupportsDtype 1580266844
1426362452 https://github.com/pydata/xarray/pull/7521#issuecomment-1426362452 https://api.github.com/repos/pydata/xarray/issues/7521 IC_kwDOAMm_X85VBJBU headtr1ck 43316012 2023-02-10T21:23:15Z 2023-02-10T21:23:15Z COLLABORATOR

@Illviljan I was away for quite some time, do you have an idea what is wrong with mypy-3.9?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   use numpys SupportsDtype 1580266844

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);