issue_comments

Table actions

7 rows where author_association = "COLLABORATOR", issue = 1412019155 and user = 43316012 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • headtr1ck · 7 ✖

issue 1

  • Lazy Imports · 7 ✖

author_association 1

  • COLLABORATOR · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1317646082 https://github.com/pydata/xarray/pull/7179#issuecomment-1317646082 https://api.github.com/repos/pydata/xarray/issues/7179 IC_kwDOAMm_X85Oia8C headtr1ck 43316012 2022-11-16T20:44:36Z 2022-11-16T20:46:15Z COLLABORATOR

I don't think this is a bug in importlib but rather pyodide. They seem to add a hook to importlib (which is allowed, but probably causing this issue?)

Edit: The error message from pyodide seems more like this is intentional? Is scipy really installed correctly?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Lazy Imports 1412019155
1288072721 https://github.com/pydata/xarray/pull/7179#issuecomment-1288072721 https://api.github.com/repos/pydata/xarray/issues/7179 IC_kwDOAMm_X85Mxm4R headtr1ck 43316012 2022-10-23T10:02:46Z 2022-10-23T10:02:46Z COLLABORATOR

It seems that cfgrib has its own xarray_plugin now. Should the internal version be deprecated?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Lazy Imports 1412019155
1287920868 https://github.com/pydata/xarray/pull/7179#issuecomment-1287920868 https://api.github.com/repos/pydata/xarray/issues/7179 IC_kwDOAMm_X85MxBzk headtr1ck 43316012 2022-10-22T21:10:53Z 2022-10-22T21:10:53Z COLLABORATOR

I managed to get dask.array lazy as well, but dask.utils is still imported by backends.locks.

Someone else has to tackle this, I am not too familiar with this...

This got the import time quite low. I am happy with this now :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Lazy Imports 1412019155
1287814936 https://github.com/pydata/xarray/pull/7179#issuecomment-1287814936 https://api.github.com/repos/pydata/xarray/issues/7179 IC_kwDOAMm_X85Mwn8Y headtr1ck 43316012 2022-10-22T14:47:16Z 2022-10-22T21:09:25Z COLLABORATOR

Seems like it is but a good idea to mess with sys.modules in pytest. Anyone got an idea how to solve that?

Edit: solved :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Lazy Imports 1412019155
1287807063 https://github.com/pydata/xarray/pull/7179#issuecomment-1287807063 https://api.github.com/repos/pydata/xarray/issues/7179 IC_kwDOAMm_X85MwmBX headtr1ck 43316012 2022-10-22T14:15:48Z 2022-10-22T14:17:19Z COLLABORATOR

Now I have made every module lazy that is not too much work, this includes: matplotlib, flox and all backends.

The only remaining large import is dask.array, here I have to check if that is possible to make lazy? This alone is 500ms import time, since it also imports numba, scipy and sparse... Maybe we could even open a ticket at dask about this topic as well?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Lazy Imports 1412019155
1283016719 https://github.com/pydata/xarray/pull/7179#issuecomment-1283016719 https://api.github.com/repos/pydata/xarray/issues/7179 IC_kwDOAMm_X85MeUgP headtr1ck 43316012 2022-10-18T21:18:14Z 2022-10-18T21:18:14Z COLLABORATOR

The simplest solution would be to add a simple unit test that checks that blacklisted packets are not in sys.modules.

For import timings we have asv, but that is not run so often.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Lazy Imports 1412019155
1282951823 https://github.com/pydata/xarray/pull/7179#issuecomment-1282951823 https://api.github.com/repos/pydata/xarray/issues/7179 IC_kwDOAMm_X85MeEqP headtr1ck 43316012 2022-10-18T20:16:18Z 2022-10-18T20:16:18Z COLLABORATOR

Not as much of an improvement as I thought, but shaving off another 20ms.

I can see if I can bring it down even further...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Lazy Imports 1412019155

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);