issue_comments

Table actions

3 rows where author_association = "COLLABORATOR", issue = 1377097243 and user = 43316012 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • headtr1ck · 3 ✖

issue 1

  • Add parse_dims func · 3 ✖

author_association 1

  • COLLABORATOR · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1265200159 https://github.com/pydata/xarray/pull/7051#issuecomment-1265200159 https://api.github.com/repos/pydata/xarray/issues/7051 IC_kwDOAMm_X85LaWwf headtr1ck 43316012 2022-10-03T09:51:34Z 2022-10-03T09:51:34Z COLLABORATOR

I think it is best to implement two functions, one for sets of dims and one for sequences of dims. This will be easier to type/read/use than trying to put both kinds into one function.

See also #7094

Maybe parse_dims and parse_ordered_dims?

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add parse_dims func 1377097243
1252833112 https://github.com/pydata/xarray/pull/7051#issuecomment-1252833112 https://api.github.com/repos/pydata/xarray/issues/7051 IC_kwDOAMm_X85KrLdY headtr1ck 43316012 2022-09-20T19:50:52Z 2022-09-20T19:50:52Z COLLABORATOR

Yes! ... is the better synonym — None is somewhat an artifact of history. So +1 for replace_none, which maybe we can gradually turn to False by default over time.

Nothing wrong with None, it is just pythons default.

The intention of replace_none=False was to leave None as None, which is important for some low level functions as they might be optimized (like numpy sum, which sums over all axes for None).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add parse_dims func 1377097243
1252586358 https://github.com/pydata/xarray/pull/7051#issuecomment-1252586358 https://api.github.com/repos/pydata/xarray/issues/7051 IC_kwDOAMm_X85KqPN2 headtr1ck 43316012 2022-09-20T16:14:17Z 2022-09-20T16:14:17Z COLLABORATOR

I might have thought both of them could be encapsulated in a single func... Maybe that's infix_dims, or fine to rename!

I always thought that these two methods are incompatible. But I guess ... Is synonym for None (= all dims) and if ... Appears in an iterable, it just means replace it with all leftover dims.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add parse_dims func 1377097243

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);