issue_comments

Table actions

11 rows where author_association = "COLLABORATOR", issue = 1353467346 and user = 43316012 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • headtr1ck · 11 ✖

issue 1

  • Fixed type errors in `mypy` GitHub Action · 11 ✖

author_association 1

  • COLLABORATOR · 11 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1321627289 https://github.com/pydata/xarray/pull/6963#issuecomment-1321627289 https://api.github.com/repos/pydata/xarray/issues/6963 IC_kwDOAMm_X85Oxm6Z headtr1ck 43316012 2022-11-21T08:04:26Z 2022-11-21T08:04:26Z COLLABORATOR

This one throws errors still: python -m mypy --install-types --non-interactive --python-version 3.8 --follow-imports=silent Did it ever crash if we used the normal mypy CI but with changed python version?

I don't think we ever used --python-version outside of this PR.

We should report this mypy bug...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fixed type errors in `mypy` GitHub Action 1353467346
1321250701 https://github.com/pydata/xarray/pull/6963#issuecomment-1321250701 https://api.github.com/repos/pydata/xarray/issues/6963 IC_kwDOAMm_X85OwK-N headtr1ck 43316012 2022-11-20T21:44:36Z 2022-11-20T21:44:36Z COLLABORATOR

A good ol' copy/paste job works as expected though. :) I think we can discuss more elegant solutions in a follow up PR.

So now mypy is not crashing anymore? Thats weird, we should open an issue on mypy about this...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fixed type errors in `mypy` GitHub Action 1353467346
1278544017 https://github.com/pydata/xarray/pull/6963#issuecomment-1278544017 https://api.github.com/repos/pydata/xarray/issues/6963 IC_kwDOAMm_X85MNQiR headtr1ck 43316012 2022-10-14T06:29:09Z 2022-10-17T06:05:46Z COLLABORATOR

It seems that mypy encountered an unrecoverable runtime error. We should probably report that to mypy, but I cannot reproduce it locally, yet alone create a MVCE.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fixed type errors in `mypy` GitHub Action 1353467346
1278122387 https://github.com/pydata/xarray/pull/6963#issuecomment-1278122387 https://api.github.com/repos/pydata/xarray/issues/6963 IC_kwDOAMm_X85MLpmT headtr1ck 43316012 2022-10-13T20:07:11Z 2022-10-13T20:07:11Z COLLABORATOR

Hmmm, these errors should be fixed in the latest version of this PR.

The problem CI is running into is that mypy runs into an unrecoverable error parsing dask, this I cannot reproduce locally.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fixed type errors in `mypy` GitHub Action 1353467346
1277983839 https://github.com/pydata/xarray/pull/6963#issuecomment-1277983839 https://api.github.com/repos/pydata/xarray/issues/6963 IC_kwDOAMm_X85MLHxf headtr1ck 43316012 2022-10-13T18:02:19Z 2022-10-13T18:02:19Z COLLABORATOR

I cannot reproduce the mypy error locally. Does this break for someone else?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fixed type errors in `mypy` GitHub Action 1353467346
1277948696 https://github.com/pydata/xarray/pull/6963#issuecomment-1277948696 https://api.github.com/repos/pydata/xarray/issues/6963 IC_kwDOAMm_X85MK_MY headtr1ck 43316012 2022-10-13T17:29:09Z 2022-10-13T17:29:09Z COLLABORATOR

Seems like dasks typing is also not compatible with python 3.8, haha

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fixed type errors in `mypy` GitHub Action 1353467346
1277933138 https://github.com/pydata/xarray/pull/6963#issuecomment-1277933138 https://api.github.com/repos/pydata/xarray/issues/6963 IC_kwDOAMm_X85MK7ZS headtr1ck 43316012 2022-10-13T17:14:44Z 2022-10-13T17:14:44Z COLLABORATOR

Seems that pyupgrade does not update tuple -> Tuple inside of Union, which is exactly what caused these problems.

Looks good to me now 👍 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fixed type errors in `mypy` GitHub Action 1353467346
1277754873 https://github.com/pydata/xarray/pull/6963#issuecomment-1277754873 https://api.github.com/repos/pydata/xarray/issues/6963 IC_kwDOAMm_X85MKP35 headtr1ck 43316012 2022-10-13T15:00:23Z 2022-10-13T15:00:23Z COLLABORATOR

@dcherian on a different issue: can we prevent that the auto labeler removes manually added labels?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fixed type errors in `mypy` GitHub Action 1353467346
1277731299 https://github.com/pydata/xarray/pull/6963#issuecomment-1277731299 https://api.github.com/repos/pydata/xarray/issues/6963 IC_kwDOAMm_X85MKKHj headtr1ck 43316012 2022-10-13T14:44:30Z 2022-10-13T14:44:30Z COLLABORATOR

When I run locally mypy --python-version 3.8 i get more errors. Maybe merge current main and let's see what new issues emerge.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fixed type errors in `mypy` GitHub Action 1353467346
1277288015 https://github.com/pydata/xarray/pull/6963#issuecomment-1277288015 https://api.github.com/repos/pydata/xarray/issues/6963 IC_kwDOAMm_X85MId5P headtr1ck 43316012 2022-10-13T09:10:38Z 2022-10-13T09:10:38Z COLLABORATOR

Could you add an additional mypy workflow to test this behavior? See https://github.com/pydata/xarray/issues/6962#issuecomment-1277287183

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fixed type errors in `mypy` GitHub Action 1353467346
1229559261 https://github.com/pydata/xarray/pull/6963#issuecomment-1229559261 https://api.github.com/repos/pydata/xarray/issues/6963 IC_kwDOAMm_X85JSZXd headtr1ck 43316012 2022-08-28T21:36:32Z 2022-08-28T21:36:32Z COLLABORATOR

That is weird, with from __future__ import annotations this should work.

Actually the pyupgrade pre-commit hook should even replace the typing versions by built-in versions.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fixed type errors in `mypy` GitHub Action 1353467346

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);