issue_comments

Table actions

9 rows where author_association = "COLLABORATOR" and issue = 1318808368 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

issue 1

  • Bump minimum numpy version to 1.20 · 9 ✖

author_association 1

  • COLLABORATOR · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1276449387 https://github.com/pydata/xarray/pull/6834#issuecomment-1276449387 https://api.github.com/repos/pydata/xarray/issues/6834 IC_kwDOAMm_X85MFRJr headtr1ck 43316012 2022-10-12T16:33:05Z 2022-10-12T16:33:05Z COLLABORATOR

We usually only fix the minor version, in this case cdms2=3.1. But it seems to work now...

LGTM!

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Bump minimum numpy version to 1.20 1318808368
1275657950 https://github.com/pydata/xarray/pull/6834#issuecomment-1275657950 https://api.github.com/repos/pydata/xarray/issues/6834 IC_kwDOAMm_X85MCP7e headtr1ck 43316012 2022-10-12T06:30:08Z 2022-10-12T06:30:08Z COLLABORATOR

Is there a reason why the minimum versions are not in the additional requirements in setup.cfg?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Bump minimum numpy version to 1.20 1318808368
1272610336 https://github.com/pydata/xarray/pull/6834#issuecomment-1272610336 https://api.github.com/repos/pydata/xarray/issues/6834 IC_kwDOAMm_X85L2n4g headtr1ck 43316012 2022-10-09T19:16:47Z 2022-10-09T19:16:47Z COLLABORATOR

sorry! trying to fix this in conda-forge/flox-feedstock#22

Thanks! Do we have to clear some micromamba cache for this to work immediately or should it just work after some days?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Bump minimum numpy version to 1.20 1318808368
1272397924 https://github.com/pydata/xarray/pull/6834#issuecomment-1272397924 https://api.github.com/repos/pydata/xarray/issues/6834 IC_kwDOAMm_X85L10Bk headtr1ck 43316012 2022-10-08T21:09:11Z 2022-10-08T21:09:11Z COLLABORATOR

@dcherian I see that you were working on this the last time. Do you have any idea why mamba fails to resolve the environment (for min-all-deps)? With netcdf4=1.5.3 it fails for some python dependencies and with 1.5.4 it fails to find the correct cmds2?

We should really merge this, since all CI runs are currently broken due to new flox requiring numpy>=1.20

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Bump minimum numpy version to 1.20 1318808368
1269011817 https://github.com/pydata/xarray/pull/6834#issuecomment-1269011817 https://api.github.com/repos/pydata/xarray/issues/6834 IC_kwDOAMm_X85Lo5Vp headtr1ck 43316012 2022-10-05T21:43:57Z 2022-10-05T21:43:57Z COLLABORATOR

I got rid of the complete npcompat module. Not sure if you actually want to keep it around in case new incompatibilities arise? But I guess we can always add it back.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Bump minimum numpy version to 1.20 1318808368
1269008079 https://github.com/pydata/xarray/pull/6834#issuecomment-1269008079 https://api.github.com/repos/pydata/xarray/issues/6834 IC_kwDOAMm_X85Lo4bP headtr1ck 43316012 2022-10-05T21:39:23Z 2022-10-05T21:39:23Z COLLABORATOR

Anyone know why min all deps fails? As far as I can tell the only requirement of netCDF is python 3.8?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Bump minimum numpy version to 1.20 1318808368
1196479190 https://github.com/pydata/xarray/pull/6834#issuecomment-1196479190 https://api.github.com/repos/pydata/xarray/issues/6834 IC_kwDOAMm_X85HUNLW headtr1ck 43316012 2022-07-27T09:20:06Z 2022-07-27T09:20:06Z COLLABORATOR

Ok I think I found my misunderstanding.

Instead of dropping versions older than 18 month we want the oldest supported version to be at least 18 month old.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Bump minimum numpy version to 1.20 1318808368
1196464402 https://github.com/pydata/xarray/pull/6834#issuecomment-1196464402 https://api.github.com/repos/pydata/xarray/issues/6834 IC_kwDOAMm_X85HUJkS headtr1ck 43316012 2022-07-27T09:06:58Z 2022-07-27T09:06:58Z COLLABORATOR

It's this table https://numpy.org/neps/nep-0029-deprecation_policy.html#drop-schedule : On Jan 31, 2023 drop support for NumPy 1.20 (initially released on Jan 31, 2021)

We are dropping 1.19 here, where this table says: "On Jun 21, 2022 drop support for NumPy 1.19" What is now correct?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Bump minimum numpy version to 1.20 1318808368
1196048636 https://github.com/pydata/xarray/pull/6834#issuecomment-1196048636 https://api.github.com/repos/pydata/xarray/issues/6834 IC_kwDOAMm_X85HSkD8 headtr1ck 43316012 2022-07-26T22:37:24Z 2022-07-26T22:37:24Z COLLABORATOR

Ok seems @Illviljan and myself were a few month off xD https://github.com/pydata/xarray/pull/6821#issuecomment-1193378283.

Nvmd then :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Bump minimum numpy version to 1.20 1318808368

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);