issue_comments

Table actions

3 rows where author_association = "COLLABORATOR", issue = 1315959612 and user = 43316012 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • headtr1ck · 3 ✖

issue 1

  • Fix numpy 1.20 incompatibility · 3 ✖

author_association 1

  • COLLABORATOR · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1193384057 https://github.com/pydata/xarray/pull/6821#issuecomment-1193384057 https://api.github.com/repos/pydata/xarray/issues/6821 IC_kwDOAMm_X85HIZh5 headtr1ck 43316012 2022-07-24T19:56:07Z 2022-07-24T19:56:07Z COLLABORATOR

When we bump the minimum numpy version to 1.20 we should rework the npcompat module since much of it is no longer required. But yet, we can do that in another PR.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix numpy 1.20 incompatibility 1315959612
1193375611 https://github.com/pydata/xarray/pull/6821#issuecomment-1193375611 https://api.github.com/repos/pydata/xarray/issues/6821 IC_kwDOAMm_X85HIXd7 headtr1ck 43316012 2022-07-24T19:03:37Z 2022-07-24T19:03:37Z COLLABORATOR

Are we still supporting numpy 1.20? If we are, presumably it should be covered in our min-versions CI?

We are supporting >=1.19. Is there a rule when older versions are dropped?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix numpy 1.20 incompatibility 1315959612
1193359918 https://github.com/pydata/xarray/pull/6821#issuecomment-1193359918 https://api.github.com/repos/pydata/xarray/issues/6821 IC_kwDOAMm_X85HITou headtr1ck 43316012 2022-07-24T17:16:47Z 2022-07-24T17:16:47Z COLLABORATOR

Verified locally that numpy 1.20 works. Is there a way to run a custom CI run with numpy 1.20?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix numpy 1.20 incompatibility 1315959612

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);