issue_comments: 998298778

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/6086#issuecomment-998298778 https://api.github.com/repos/pydata/xarray/issues/6086 998298778 IC_kwDOAMm_X847gNSa 1217238 2021-12-20T21:55:23Z 2021-12-20T21:55:23Z MEMBER

I think that with @runtime_checkable then once mypy considers these the same type then this would pass, but I might have completely misunderstood how that works (meaning then we would probably need to relax the isinstance check).

This is just an internal check in xarray, verifying that _variables is always a Python dict. I would be fine turning this off, certainly at least for tests with the new custom mapping.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1084220684