issue_comments: 983747745

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5984#issuecomment-983747745 https://api.github.com/repos/pydata/xarray/issues/5984 983747745 IC_kwDOAMm_X846osyh 10194086 2021-12-01T15:22:27Z 2021-12-01T15:22:27Z MEMBER

Any objections to merging this as is? If we don't disallow xr.DataArray(da) this is a clear advantage over the current version.

However,

```python xr.DataArray(da).data is da.data # True xr.DataArray(da.data).data is da.data # True

while

da.copy().data is da.data # False (deep=True is the default) ``` might just be surprising in some situations.

(Just for completeness - xr.DataArray(da, **kwargs) does a good job at erroring if the kwargs are not compatible with da.)

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1052740367