issue_comments: 967729952

Unfortunately, I can't predict what the Jupyter project could do in the future in terms of stripping inline CSS or the html hidden attribute. I don't get the sense that this would be happening anytime soon, but I can't promise it would never happen.

I sent in the PR because I am an author of a JupyterLab extension that we plan to use at NERSC, which includes Bootstrap, and we ran into the problem of the xarray repr() returning a hidden div (blank output) in a regular notebook (trusted). Any JupyterLab extension that includes Bootstrap or has a css rule that affects how the browser treats the html hidden attribute will have similar problems with xarray in notebooks. It seemed appropriate to flag it and send in a fix before it becomes a bigger problem.

There is an existing test in xarray (which passes) that checks for the css content. If you wanted to add another test that actually spins up a Jupyter instance to test it further, that is possible but definitely more involved and may not be a fast test to run.

I think this could be merged as-is, but feedback is always welcome. If there are any suggestions for improving this PR further to resolve the existing issue please let me know.

Longer-term, embedding html/css may not be the way to go, but I think that falls outside the scope of this PR. We can arrange to chat with some Jupyter devs if there is interest in a discussion about longer-term solutions for the rendering in notebooks and/or JupyterLab, just let me know if you want to do that. @benbovy

On Fri, Nov 12, 2021 at 2:26 PM Maximilian Roos @.***> wrote:

Hi @mlhenderson https://github.com/mlhenderson — I don't know this well — if you are confident that @benbovy https://github.com/benbovy 's concern is not pressing, then we could merge? (unless @benbovy https://github.com/benbovy you are confident that it is a concern!)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/5880#issuecomment-967701381, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVNKLNE6NK653KHEUYDX5LULWICVANCNFSM5GMKPTKA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.