issue_comments: 964450835

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5961#issuecomment-964450835 https://api.github.com/repos/pydata/xarray/issues/5961 964450835 IC_kwDOAMm_X845fFoT 35968931 2021-11-09T19:08:09Z 2021-11-09T19:24:32Z MEMBER

It just seems confusing to have an object referred to as ._variables which actually is just as much a container of child DataTree nodes as it is of variables...

Also the DataTree class needs to wrap this "manifest" too (otherwise I'm storing children in multiple places at once), and so I want it to make sense in that context too.

On Tue, 9 Nov 2021, 13:46 Stephan Hoyer, @.***> wrote:

How about making custom Mapping for use as Dataset._variables directly, which directly is a mapping of dataset variables? You could still be storing the underlying variables in a different way.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/5961#issuecomment-964433424, or unsubscribe https://github.com/notifications/unsubscribe-auth/AISNPI4LEDDTEGYBWJ7VK6LULFT75ANCNFSM5HVPT5AA . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1048697792