issue_comments: 964409224

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5734#issuecomment-964409224 https://api.github.com/repos/pydata/xarray/issues/5734 964409224 IC_kwDOAMm_X845e7eI 2448579 2021-11-09T18:14:38Z 2021-11-09T18:14:38Z MEMBER

Benchmarks are looking good (npg=True means use numpy groupies). Big gains (10-20x) for large number of groups (100), especially with dask.

``` [ 2.78%] ··· groupby.GroupBy.time_agg_large_num_groups ok [ 2.78%] ··· ======== ========== =========== ========== =========== -- ndim / npg
-------- --------------------------------------------- method 1 / True 1 / False 2 / True 2 / False ======== ========== =========== ========== =========== sum 8.38±0ms 101±0ms 9.54±0ms 136±0ms
mean 7.12±0ms 101±0ms 9.74±0ms 148±0ms
======== ========== =========== ========== ===========

[ 5.56%] ··· groupby.GroupBy.time_agg_small_num_groups ok [ 5.56%] ··· ======== ========== =========== ========== =========== -- ndim / npg
-------- --------------------------------------------- method 1 / True 1 / False 2 / True 2 / False ======== ========== =========== ========== =========== sum 8.27±0ms 4.55±0ms 9.07±0ms 8.46±0ms mean 7.19±0ms 4.50±0ms 9.24±0ms 8.36±0ms ======== ========== =========== ========== ===========

[ 8.33%] ··· groupby.GroupBy.time_init ok [ 8.33%] ··· ====== ========== ndim
------ ---------- 1 1.72±0ms 2 4.06±0ms ====== ==========

[ 11.11%] ··· groupby.GroupByDask.time_agg_large_num_groups ok [ 11.11%] ··· ======== ========== =========== ========== =========== -- ndim / npg
-------- --------------------------------------------- method 1 / True 1 / False 2 / True 2 / False ======== ========== =========== ========== =========== sum 8.41±0ms 202±0ms 9.93±0ms 226±0ms
mean 7.83±0ms 197±0ms 10.7±0ms 213±0ms
======== ========== =========== ========== ===========

[ 13.89%] ··· groupby.GroupByDask.time_agg_small_num_groups ok [ 13.89%] ··· ======== ========== =========== ========== =========== -- ndim / npg
-------- --------------------------------------------- method 1 / True 1 / False 2 / True 2 / False ======== ========== =========== ========== =========== sum 8.41±0ms 8.99±0ms 10.5±0ms 12.5±0ms mean 7.98±0ms 8.67±0ms 10.1±0ms 12.2±0ms ======== ========== =========== ========== ===========

[ 16.67%] ··· groupby.GroupByDask.time_init ok [ 16.67%] ··· ====== ========== ndim
------ ---------- 1 1.77±0ms 2 4.06±0ms ====== ==========

[ 36.11%] ··· groupby.Resample.time_agg_large_num_groups ok [ 36.11%] ··· ======== ========== =========== ========== =========== -- ndim / npg
-------- --------------------------------------------- method 1 / True 1 / False 2 / True 2 / False ======== ========== =========== ========== =========== sum 17.2±0ms 83.3±0ms 17.0±0ms 93.5±0ms mean 15.5±0ms 91.0±0ms 17.4±0ms 101±0ms
======== ========== =========== ========== ===========

[ 38.89%] ··· groupby.Resample.time_agg_small_num_groups ok [ 38.89%] ··· ======== ========== =========== ========== =========== -- ndim / npg
-------- --------------------------------------------- method 1 / True 1 / False 2 / True 2 / False ======== ========== =========== ========== =========== sum 16.7±0ms 12.3±0ms 16.7±0ms 13.3±0ms mean 15.2±0ms 12.5±0ms 19.3±0ms 13.9±0ms ======== ========== =========== ========== ===========

[ 41.67%] ··· groupby.Resample.time_init ok [ 41.67%] ··· ====== ========== ndim
------ ---------- 1 7.46±0ms 2 7.26±0ms ====== ==========

[ 44.44%] ··· groupby.ResampleDask.time_agg_large_num_groups ok [ 44.44%] ··· ======== ========== =========== ========== =========== -- ndim / npg
-------- --------------------------------------------- method 1 / True 1 / False 2 / True 2 / False ======== ========== =========== ========== =========== sum 22.3±0ms 561±0ms 28.3±0ms 607±0ms
mean 22.2±0ms 344±0ms 27.3±0ms 371±0ms
======== ========== =========== ========== ===========

[ 47.22%] ··· groupby.ResampleDask.time_agg_small_num_groups ok [ 47.22%] ··· ======== ========== =========== ========== =========== -- ndim / npg
-------- --------------------------------------------- method 1 / True 1 / False 2 / True 2 / False ======== ========== =========== ========== =========== sum 17.7±0ms 31.2±0ms 20.0±0ms 34.2±0ms mean 17.2±0ms 24.4±0ms 19.9±0ms 26.6±0ms ======== ========== =========== ========== ===========

[ 50.00%] ··· groupby.ResampleDask.time_init ok [ 50.00%] ··· ====== ========== ndim
------ ---------- 1 7.43±0ms 2 6.91±0ms == ```

 
{
    "total_count": 3,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 3,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   978356586