home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 957363773

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5692#issuecomment-957363773 https://api.github.com/repos/pydata/xarray/issues/5692 957363773 IC_kwDOAMm_X845EDY9 4160723 2021-11-02T11:45:57Z 2021-11-02T11:45:57Z MEMBER

I really appreciate your efforts here! This is a giant refactoring PR. It's very important work but I know it can be hard to land.

Thanks @shoyer! On a positive note (starting a new week after a long week-end helps), lots of important tasks are done now, there has been good progress.

I wonder if there are things we could do to make this easier to land -- maybe we could defer some of these fixes to a later PR, if we wait on disabling implicit indexes?

We'll need to make all tests pass, but yes I'll try to see if we can provide some temporary (dirty) fixes that at least work under the current (legacy) data model (dimension coordinates with pandas indexes).

{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
  966983801
Powered by Datasette · Queries took 0.846ms · About: xarray-datasette