issue_comments: 955082380

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5871#issuecomment-955082380 https://api.github.com/repos/pydata/xarray/issues/5871 955082380 IC_kwDOAMm_X8447WaM 14371165 2021-10-29T22:28:59Z 2021-10-29T22:28:59Z MEMBER

This looks great, nice work!

This can be saved for a future PR but one thing I notice is that it's possible to make the unions slightly more readable using the new |-operator: python dim: Union[None, Hashable, Sequence[Hashable]] = None vs. ```python from future import annotations

dim: None | Hashable | Sequence[Hashable] = None ``` I'm unsure about the compatibility but I think it should be fine.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1028110240