issue_comments: 950891355

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/5872#issuecomment-950891355 https://api.github.com/repos/pydata/xarray/issues/5872 950891355 IC_kwDOAMm_X844rXNb 10194086 2021-10-25T12:50:05Z 2021-10-25T12:50:05Z MEMBER

I think this is an upstream issue (or intended change).

```python import numpy as np import pandas as pd

pd.Series([1.7, 0.5, np.nan]).sum(skipna=None) `` returns2.2in pandas 1.3.4 andnanin main. Pandas is used to verify the result. That means thatresultis still correct in the test butexpected` has changed.

https://github.com/pydata/xarray/blob/fdabf3bea5c750939a4a2ae60f80ed34a6aebd58/xarray/tests/test_duck_array_ops.py#L580

uses pandas

https://github.com/pydata/xarray/blob/fdabf3bea5c750939a4a2ae60f80ed34a6aebd58/xarray/tests/test_duck_array_ops.py#L262-L263

I'll go check if this is reported upstream.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1028482291