issue_comments: 950769747

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5880#issuecomment-950769747 https://api.github.com/repos/pydata/xarray/issues/5880 950769747 IC_kwDOAMm_X844q5hT 4160723 2021-10-25T10:24:02Z 2021-10-25T10:24:02Z MEMBER

Thanks @mlhenderson for submitting this PR!

It looks good to me, I prefer this inline CSS workaround than the (very hacky) hidden HTML attribute workaround. My only concern is: are we sure that inline CSS won't get stripped out too in notebook front-ends in the future? (in which case the hidden solution will still work, unless it also gets removed like for GitHub's notebook renderer).

Not sure why this fix was implemented in sphinx-book-theme and not in xarray directly...

It guess it depends on which order Xarray's vs. Bootstrap's vs. Sphinx-Book's CSS is injected. Not sure about the actual order.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1031724989