home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 948912399

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5880#issuecomment-948912399 https://api.github.com/repos/pydata/xarray/issues/5880 948912399 IC_kwDOAMm_X844j0EP 2807085 2021-10-21T18:57:17Z 2021-10-21T18:57:17Z CONTRIBUTOR

I looked at the other issues, and this should resolve the sphinx-book issue in https://github.com/executablebooks/sphinx-book-theme/issues/238#issuecomment-714784321 without needing a special exception for that codebase.

For https://github.com/pydata/xarray/pull/4053: Github rendered notebooks will still not look great because it will strip the inline css of the xr-wrap div (and all css). All of the actual styling (placement, color, etc) for that html block is in the css style block that gets stripped. Fixing that is a different problem from the untrusted notebook case, which is less aggressive, although that may not be the case in the future. You would need to render the content in a different format (maybe an image) for the saved notebook to get around losing css entirely.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1031724989
Powered by Datasette · Queries took 160.686ms · About: xarray-datasette