issue_comments: 945825537

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4760#issuecomment-945825537 https://api.github.com/repos/pydata/xarray/issues/4760 945825537 IC_kwDOAMm_X844YCcB 10194086 2021-10-18T14:21:56Z 2021-10-18T14:21:56Z MEMBER

I closed the PR by accident but I think I'll keep it closed, unless there is interest to get this in. Testing dtypes could be an interesting option, however,

  • there are O(1000) tests that do not preserve dtype - so this would be an enormous cleanup required if we ever seriously wanted to do this
  • some elements cannot preserve dtypes (str types in pandas index (not sure what the index refactor does here) and empty str arrays)
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   778069594