home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 944278576

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5847#issuecomment-944278576 https://api.github.com/repos/pydata/xarray/issues/5847 944278576 IC_kwDOAMm_X844SIww 31376402 2021-10-15T13:01:32Z 2021-10-15T13:02:24Z CONTRIBUTOR

Just checked and this cannot be tested for pint units, there is already a comment in there explaining this:

```python

TODO make coord a Quantity once unit-aware indexes supported"

``` Since the slice units come from a coordinate these units can't be pint units (at least not yet).

I added a new test for the units in the title of a slice line plot, also added the same comment about pint units.

Who should I ping for the PR approval?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1021396447
Powered by Datasette · Queries took 0.861ms · About: xarray-datasette