home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 940127873

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5845#issuecomment-940127873 https://api.github.com/repos/pydata/xarray/issues/5845 940127873 IC_kwDOAMm_X844CTaB 14808389 2021-10-11T15:23:06Z 2021-10-11T15:24:43Z MEMBER

I might be confusing something, but I thought preprocessing selectors were executed at build time? So if you build the noarch: python package in an environment that has python=3.7 you will keep the importlib_metadata while in a different one with python=3.8 it will be removed?

The easiest way to figure this out would be to build in a py38 environment, install in a py37 environment and then try to import it (i.e. trigger the code path that uses importlib.metadata). If that works, then it would be fine to merge now.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  1020407925
Powered by Datasette · Queries took 0.503ms · About: xarray-datasette