issue_comments: 939438771

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5848#issuecomment-939438771 https://api.github.com/repos/pydata/xarray/issues/5848 939438771 IC_kwDOAMm_X843_rKz 14808389 2021-10-10T09:28:22Z 2021-10-10T09:28:22Z MEMBER

Just for reference, this is the output for pre-commit run --all-files (hidden in Command results → python -m pre_commit run --all-files):

``` [INFO] Initializing environment for https://github.com/pre-commit/mirrors-mypy:numpy,types-PyYAML,types-pkg_resources,types-python-dateutil,types-pytz,typing-extensions==3.10.0.0. [INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/PyCQA/isort. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/psf/black. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/keewis/blackdoc. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://gitlab.com/pycqa/flake8. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pre-commit/mirrors-mypy. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... Trim Trailing Whitespace.................................................Passed Fix End of Files.........................................................Passed Check Yaml...............................................................Passed isort....................................................................Passed black....................................................................Passed blackdoc.................................................................Passed flake8...................................................................Passed mypy.....................................................................Failed - hook id: mypy - exit code: 2 xarray/core/_typed_ops.py: error: Duplicate module named "xarray.core._typed_ops" (also at "xarray/core/_typed_ops.pyi") xarray/core/_typed_ops.py: note: Are you missing an __init__.py? Alternatively, consider using --exclude to avoid checking one of them. Found 1 error in 1 file (errors prevented further checking) ```

to avoid things like this we should probably replace our custom workflow with pre-commit.ci (and set autofix_prs: false).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1021839082