issue_comments: 939371374

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5845#issuecomment-939371374 https://api.github.com/repos/pydata/xarray/issues/5845 939371374 IC_kwDOAMm_X843_atu 14808389 2021-10-09T22:41:15Z 2021-10-10T16:40:21Z MEMBER

is there any reason not to merge this?

the issue is that with conda we can either always install importlib_metadata or not at all: conda doesn't support noarch_python packages with preprocessing selectors (see the comments around https://github.com/pydata/xarray/issues/4295#issuecomment-667657310 for more discussion).

importlib.metadata is included in python>=3.8, which we can officially require from end of December this year.

All of this means that if we want to merge this now we have to decide between not releasing until we can drop python=3.7 or always installing importlib_metadata (which is what the pint feedstock does). However, I guess the cleanest way would be to wait until we can require python>=3.8.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   1020407925