issue_comments: 933160264

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5734#issuecomment-933160264 https://api.github.com/repos/pydata/xarray/issues/5734 933160264 IC_kwDOAMm_X843nuVI 2448579 2021-10-04T05:42:51Z 2021-11-11T20:58:53Z MEMBER

!!!

The only failures are in test_units.py so now I think we can figure out how to implement this cleanly.

FAILED xarray/tests/test_units.py::TestDataArray::test_computation_objects[float64-method_groupby-data] FAILED xarray/tests/test_units.py::TestDataArray::test_computation_objects[float64-method_groupby_bins-data] FAILED xarray/tests/test_units.py::TestDataArray::test_computation_objects[int64-method_groupby-data] FAILED xarray/tests/test_units.py::TestDataArray::test_computation_objects[int64-method_groupby_bins-data] FAILED xarray/tests/test_units.py::TestDataArray::test_resample[float64] - pi... FAILED xarray/tests/test_units.py::TestDataArray::test_resample[int64] - pint... FAILED xarray/tests/test_units.py::TestDataset::test_computation_objects[float64-data-method_groupby_bins] FAILED xarray/tests/test_units.py::TestDataset::test_computation_objects[int64-data-method_groupby_bins] FAILED xarray/tests/test_units.py::TestDataset::test_resample[float64-data] FAILED xarray/tests/test_units.py::TestDataset::test_resample[int64-data] - p...

I like @max-sixty's suggestion of generating the reductions like generate_ops.py. It seems like a good first step would be to refactor the existing reductions in a separate PR.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
   978356586