home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 927232092

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5776#issuecomment-927232092 https://api.github.com/repos/pydata/xarray/issues/5776 927232092 IC_kwDOAMm_X843RHBc 23625371 2021-09-26T04:59:24Z 2021-09-26T04:59:24Z CONTRIBUTOR

The only other thing this needs is a test to check that the error is raised with the correct message (i.e. pytest.raises(TypeError, match="may fix this issue")

I believe that's covered by https://github.com/pydata/xarray/blob/ec2657bfc1a426aa3559243b02ecf48de6673506/xarray/tests/test_combine.py#L1109 (i.e. no change is needed to the existing code)

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  990509161
Powered by Datasette · Queries took 155.746ms · About: xarray-datasette