home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 927141507

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3781#issuecomment-927141507 https://api.github.com/repos/pydata/xarray/issues/3781 927141507 IC_kwDOAMm_X843Qw6D 488992 2021-09-25T16:01:02Z 2021-09-25T16:02:41Z CONTRIBUTOR

I'm currently studying this problem in depth and I noticed that while the threaded scheduler uses a lock that is defined in function of the file name (as the key):

https://github.com/pydata/xarray/blob/8d23032ecf20545cd320cfb552d8febef73cd69c/xarray/backends/locks.py#L24-L32

the process-based scheduler throws away the key:

https://github.com/pydata/xarray/blob/8d23032ecf20545cd320cfb552d8febef73cd69c/xarray/backends/locks.py#L35-L39

I'm not sure yet what are the consequences and logical interpretation of that, but I would like to reraise @bcbnz's question above: should this scenario simply raise a NotImplemented error because it cannot be supported?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  567678992
Powered by Datasette · Queries took 0.686ms · About: xarray-datasette