issue_comments: 925987285

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5692#issuecomment-925987285 https://api.github.com/repos/pydata/xarray/issues/5692 925987285 IC_kwDOAMm_X843MXHV 4160723 2021-09-23T16:52:10Z 2021-09-23T16:52:10Z MEMBER

Yep I've seen those issues.

There's a lot of things going on in #3438. I wonder if the goal of chaining rename_dims, set_index, stack, etc. in the example shown in that issue wasn't ultimately to circumvent the limitation of dimension coordinates, which is not necessary anymore with explicit indexes. More particularly, neither rename_dims nor stack should cause drop-in replacement of other variables as a side effect in this PR.

Regarding #4108, I think this is not necessary anymore with explicit indexes. Since indexes are allowed for non-dimension coordinates too, we can (and it's perhaps more consistent) to preserve any existing index before/after renaming.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   966983801