issue_comments: 925966420

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5692#issuecomment-925966420 https://api.github.com/repos/pydata/xarray/issues/5692 925966420 IC_kwDOAMm_X843MSBU 14808389 2021-09-23T16:23:05Z 2021-09-23T16:24:58Z MEMBER

FYI, this was forbidden in #3645

The discussion for that is in #3438. In short, in addition to renaming, rename* did replace other variables, which I think we should only allow when explicitly requested (e.g. by requiring replace=True), regardless of what it does with indexes. It also contained a bug related to the indexes, which I think @dcherian was trying to fix in #4108.

In any case, it would really be good to come up with a consistent API in #4825, and I agree that the index refactor seems like a good time for that.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   966983801