issue_comments: 920227674

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5796#issuecomment-920227674 https://api.github.com/repos/pydata/xarray/issues/5796 920227674 IC_kwDOAMm_X8422Y9a 14371165 2021-09-15T17:37:48Z 2021-09-15T17:41:47Z MEMBER

Do you mean skipping those that require bottleneck rather than relying on asv to handle the crash? If so, sounds good

Hmm, I was just thinking installing all possible dependencies. But I think I've simply misunderstood the tests and why they were crashing.

The Benchmark no label triggered seems to have succeded but still failed? Anyone understands what the error means? ``` [100.00%] ··· unstacking.UnstackingDask.time_unstack_slow 32.7±0.3ms

BENCHMARKS NOT SIGNIFICANTLY CHANGED. + grep 'Traceback \|failed\|PERFORMANCE DECREASED' benchmarks.log + exit 1 ++ '[' 1 = 1 ']' ++ '[' -x /usr/bin/clear_console ']' ++ /usr/bin/clear_console -q Error: Process completed with exit code 1. ```

Edit: I think I understand now. We get a bunch of Traceback errors, that's why it's erroring even though the performance didn't change.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   996475523