home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 919706767

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5796#issuecomment-919706767 https://api.github.com/repos/pydata/xarray/issues/5796 919706767 IC_kwDOAMm_X8420ZyP 14371165 2021-09-15T05:15:29Z 2021-09-15T07:44:21Z MEMBER

Here's some things besides not getting green ticks @max-sixty: * Long times, +240 minutes. scikit had it down to like 13min somehow. What's the bottleneck? Which tests are super slow? * A lot of printed errors which makes the report very messy, go through each test and fix those. Not necessary for this PR though. * asv.conf.json has been moved. If you have any idea how to trigger this job inside asv_bench that would be nice. * Should we align benchmark folder names? Numpy? * Add more required installs? bottleneck for examples crashes tests because it isn't installed. Add all the non-required as well? * Can a normal user add and remove labels? I set this up so that I don't have to deal with the nightmare of setting up asv locally. Would be nice to avoid having to ask you over and over again to add/remove labels. To trigger it.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  996475523
Powered by Datasette · Queries took 0.747ms · About: xarray-datasette